Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional npm dependencies #30

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Fedoseew
Copy link

@Fedoseew Fedoseew commented Mar 4, 2025

No description provided.

Copy link
Contributor

@Gavrilov-Ivan Gavrilov-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

  1. Change the path to additional package-lock.json: jmix-dependencies/additional/npm/X.Y.Z/package-lock.json
  2. Support ability to get last existing 'fix' version package-lock.json - we need to build archive for each fix version (X.Y.Z) but in most cases there are no changes within single minor version.
    So we don't want to add the same file for each fix version and make new release of Deptool each time.
    We need to support both X.Y and X.Y.Z variants of version directory - it should check specific fix version (X.Y.Z) first, then if not found - last existing fix versionX.Y.Z. If none of them found - it should check minor version X.Y which should be mandatory to be added on release.
    E.g. if we request resolve dependencies for release 2.5.0 - it should check versions 2.5.0 -> 2.5 (till the first match). For version 2.5.2: 2.5.2 -> 2.5.1 -> 2.5.0 -> 2.5.
    Java dependencies currently check only minor version (we expect no changes within minor version) but it wold be nice to implement the same for them too.
  3. Need to add info about it to documentation: how to get, where to add and what's gonna happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants