Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brian's help #2544

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open

Brian's help #2544

wants to merge 92 commits into from
+13,807 −13

Conversation

brianharvey
Copy link
Collaborator

Hi

djsrv added 30 commits May 28, 2019 09:01
@djsrv
Implement basic HelpDialogMorph
0993c6d
@djsrv
Add ScrollFrame to HelpDialogMorph
6ddb0d4
@djsrv
Implement basic help screen deserialization
c361112
@djsrv
Implement paragraph
0f28eff
@djsrv
Use BlockEditorMorph fixLayout in HelpDialogMorph
af9618c
@djsrv
Fetch XML from help folder
70a0caa
@djsrv
Implement column/row layout
dd7245a
@djsrv
Display scripts in help screens
dc4193f
@djsrv
Improve help screen element positioning
d5e9636
@djsrv
Allow inline blocks in help screen paragraphs
7c08e5b
@djsrv
Adjust help screen elements to fill width
b4a754b
@djsrv
Fix bugs with help screen element widths
95c85b1
@djsrv
Implement basic script diagrams
8a7799f
@djsrv
Minor syntax tweaks
3a7e2d8
@djsrv
Remove unnecessary console.log
7b85e01
@djsrv
Add padding between block and arrow
9c89e51
@djsrv
Fix comment widths
923dfb4
@djsrv
Implement help screen images
efba913
@djsrv
Temporary hack to fix help screen scrolling
966febb
@djsrv
Add block thumbnail in top-left of help screen
d422fad
@djsrv
Call changed() on help screen images after load
c35c84e
@djsrv
Change help screen padding
2f2ef96
@djsrv
Add forward and bounceOffEdge screens
fa8ae10
@djsrv
Add bubble help screen
26be33e
@djsrv
Add more help screens
c0f787d
@djsrv
Allow gaps in annotation positioning
1c55486
@djsrv
Make arrows originate from annotation's first line
f9f64f3
@djsrv
Add reverse arrows in diagrams
00a235f
@djsrv
Add custom block support to help screens
0f89a34
@djsrv
Fix help screen annotation positioning
716352e 
Base position on center of first line, not center of the entire morph
djsrv and others added 30 commits July 16, 2019 13:20
@djsrv
Add shadows to bubbles in diagrams
d4c3fb1
@djsrv
Fix a bug with bubbles in diagrams
121bf4e 
Bubbles would wreck the positioning of menus and annotations
@djsrv
Update help screens
b447a2f
@djsrv
Add documentation of help screen XML
b7dd5a4
@djsrv
Lint and license help.js
ca4b1ef
@djsrv
Fix XML.md
eae4167
@djsrv @cycomachead
Capitalize title of TRANSLATING.md
a74a39a 
Co-Authored-By: Michael Ball <[email protected]>
@djsrv @cycomachead
Apply suggested improvements to TRANSLATING.md
2e68116 
Co-Authored-By: Michael Ball <[email protected]>
@djsrv @cycomachead
Replace whitespace instead of split+join in help.js
6494d75 
Co-Authored-By: Michael Ball <[email protected]>
@djsrv
Remove or rename variables named "screen"
0d24966 
As suggested by @cycomachead
@djsrv
Rename processText to normalizeWhitespace
9e56c0a 
As suggested by @cycomachead
@djsrv
Use ide.resourceURL to get image resource URL
076c933 
As suggested by @cycomachead
@djsrv
Rename TRANSLATING.md to README.md
752d1f6 
As suggested by @cycomachead
@djsrv @cycomachead
Make early return in showBubble clearer
29a7b85 
Co-Authored-By: Michael Ball <[email protected]>
@djsrv
Fix to last commit
624d81d
@djsrv
Combine loading of old and new help screens
283a82c
@djsrv
Load blocks from libraries in help screens
5c2a076
@djsrv
Fix script-in-script arrows in diagrams
9a835f2 
They didn’t display anymore due to a bug in the arrow detour code.
@djsrv
Update help screen font with libre alternative
4f81b96
@djsrv
Make sure help screens are rendered at double size
1e47a34
@djsrv
Fix help screen typos
b5cba01
@brianharvey
help screen changes
0fc129e 
Most of these reflect recent changes in the actual blocks.  There are three things I'd like Dylan to work on:

changePenHSVA_graph.png:  This picture, used in several help screens, includes annotations as pixels.  Could they be made translatable?

changeScale.png: descender of "g" cut off.  I noticed it on this screen, but it's a general problem.

doSwitchToCostume.png: I added a script, and as a result, the previous row extends past the right edge of the frame.  I thought maybe it was becasuse of retina, but when I disabled retina mode the same thing happened when I compiled the xml.

Thanks!
@djsrv
Add arrow-horizontal attribute for help annotations
8eb444f
@djsrv
Improve behavior of help screen text within rows
fdbecbe
@djsrv
Don't make help screen text unnecessarily wide
67369c2
@djsrv
Fix zebra coloring in help screen block definitions
cec7e58
@brianharvey
Merge branch 'help-screens' of https://github.com/djsrv/snap into pr/…
a7144f2 
…2456
@brianharvey
Revert "Merge branch 'help-screens' of https://github.com/djsrv/snap …
f4914ab 
…into pr/2456"

This reverts commit a7144f2, reversing
changes made to 0fc129e.
@brianharvey
Revert "Revert "Merge branch 'help-screens' of https://github.com/djs…
6be67d5 
…rv/snap into pr/2456""

This reverts commit f4914ab.
@brianharvey
Complete bh help edits
7f24dd8 
... but apparently I still have the wrong library so...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianharvey @djsrv