Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Clone bounds on Serialize impls #71

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Remove unnecessary Clone bounds on Serialize impls #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70f304
Remove unnecessary bounds on private type impls
jplatte Mar 8, 2024
0351fc9
Remove unnecessary Clone bounds on Serialize impls
jplatte Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions src/ser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,13 @@ use crate::ordmap::OrdMap;
use crate::ordset::OrdSet;
use crate::vector::Vector;

struct SeqVisitor<'de, S, A>
where
S: From<Vec<A>>,
A: Deserialize<'de>,
{
struct SeqVisitor<'de, S, A> {
phantom_s: PhantomData<S>,
phantom_a: PhantomData<A>,
phantom_lifetime: PhantomData<&'de ()>,
}

impl<'de, S, A> SeqVisitor<'de, S, A>
where
S: From<Vec<A>>,
A: Deserialize<'de>,
{
impl<'de, S, A> SeqVisitor<'de, S, A> {
pub(crate) fn new() -> SeqVisitor<'de, S, A> {
SeqVisitor {
phantom_s: PhantomData,
Expand Down Expand Up @@ -64,24 +56,14 @@ where
}
}

struct MapVisitor<'de, S, K, V>
where
S: From<Vec<(K, V)>>,
K: Deserialize<'de>,
V: Deserialize<'de>,
{
struct MapVisitor<'de, S, K, V> {
phantom_s: PhantomData<S>,
phantom_k: PhantomData<K>,
phantom_v: PhantomData<V>,
phantom_lifetime: PhantomData<&'de ()>,
}

impl<'de, S, K, V> MapVisitor<'de, S, K, V>
where
S: From<Vec<(K, V)>>,
K: Deserialize<'de>,
V: Deserialize<'de>,
{
impl<'de, S, K, V> MapVisitor<'de, S, K, V> {
pub(crate) fn new() -> MapVisitor<'de, S, K, V> {
MapVisitor {
phantom_s: PhantomData,
Expand Down Expand Up @@ -130,7 +112,7 @@ impl<'de, A: Deserialize<'de> + Ord + Clone> Deserialize<'de> for OrdSet<A> {
}
}

impl<A: Ord + Clone + Serialize> Serialize for OrdSet<A> {
impl<A: Ord + Serialize> Serialize for OrdSet<A> {
fn serialize<S>(&self, ser: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
Expand All @@ -156,7 +138,7 @@ impl<'de, K: Deserialize<'de> + Ord + Clone, V: Deserialize<'de> + Clone> Deseri
}
}

impl<K: Serialize + Ord + Clone, V: Serialize + Clone> Serialize for OrdMap<K, V> {
impl<K: Serialize + Ord, V: Serialize> Serialize for OrdMap<K, V> {
fn serialize<S>(&self, ser: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
Expand Down Expand Up @@ -187,8 +169,8 @@ where

impl<K, V, S> Serialize for HashMap<K, V, S>
where
K: Serialize + Hash + Eq + Clone,
V: Serialize + Clone,
K: Serialize + Hash + Eq,
V: Serialize,
S: BuildHasher + Default,
{
fn serialize<Ser>(&self, ser: Ser) -> Result<Ser::Ok, Ser::Error>
Expand Down Expand Up @@ -216,7 +198,7 @@ impl<'de, A: Deserialize<'de> + Hash + Eq + Clone, S: BuildHasher + Default> Des
}
}

impl<A: Serialize + Hash + Eq + Clone, S: BuildHasher + Default> Serialize for HashSet<A, S> {
impl<A: Serialize + Hash + Eq, S: BuildHasher + Default> Serialize for HashSet<A, S> {
fn serialize<Ser>(&self, ser: Ser) -> Result<Ser::Ok, Ser::Error>
where
Ser: Serializer,
Expand All @@ -240,7 +222,7 @@ impl<'de, A: Clone + Deserialize<'de>> Deserialize<'de> for Vector<A> {
}
}

impl<A: Clone + Serialize> Serialize for Vector<A> {
impl<A: Serialize> Serialize for Vector<A> {
fn serialize<S>(&self, ser: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
Expand Down
Loading