Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OrdMap::range not implement ExactSizedIterator #85

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Make OrdMap::range not implement ExactSizedIterator #85

merged 3 commits into from
Dec 16, 2024

Conversation

jneem
Copy link
Owner

@jneem jneem commented Dec 15, 2024

Fixes #84

jplatte
jplatte reviewed Dec 15, 2024
View reviewed changes
src/ord/map.rs Outdated Show resolved Hide resolved
@goffrie
Copy link
Contributor

goffrie commented Dec 15, 2024

Should RangedIter be made private now?

@jneem
Copy link
Owner Author

jneem commented Dec 15, 2024

Yes, good point. And I took the opportunity to rename RangeIter -> RangedIter so that the naming is more consistent with OrdSet.

@jneem jneem merged commit aa97553 into main Dec 16, 2024
16 of 17 checks passed
@jneem jneem mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

@goffrie goffrie goffrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OrdMap::range returns an ExactSizeIterator with the wrong size hint
3 participants
@jneem @goffrie @jplatte