-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document MSRV as 1.76 #93
Conversation
I think it would be good to add it to |
Huh, I don't have any real objection to bumping MSRV, but I'm concerned that we didn't catch this in CI. The CI runs all the tests on 1.51 -- do you know why it didn't catch this? |
I don't think CI is actually running the requested toolchain version, I'm pretty sure it's always running stable. I tried running |
Looks like you're using the deprecated |
#94 adds |
#95 should let us lower the msrv to 1.65 at least |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the various other changes, 1.76 is the minimal version (with triomphe as the bottleneck).
Co-authored-by: jneem <[email protected]>
#83 uses inline const which isn't stable until 1.79