Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History client uses the newer api/v2 endpoint #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

monsieurleberre
Copy link
Contributor

@monsieurleberre monsieurleberre commented Sep 25, 2020

↪️ Pull Request

CryptoCompare recommends to upgrade the history Api endpoint to use its v2, which apparently gives better data.
The client was still using v1

💻 Examples

image

🚨 Test instructions

History tests should still be passing

💥 Does this PR introduce a breaking change?

  • Yes
  • No

The HistoryResponse class doesn't have a list of candle data, but another nested object called HistoryResponseData, which in turn holds that list. This follows the structure of the JSON returned by v2 endpoint.

✔️ PR Todo

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    it looks like some tests have been broken for a while, but I have unfortunately no time to fix them at present

@monsieurleberre
Copy link
Contributor Author

I am not sure I understand why the semantic pull request doesn't like my commits 😬 thanks for your help!

Repository owner deleted a comment from BhavyClover Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant