History client uses the newer api/v2 endpoint #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
CryptoCompare recommends to upgrade the history Api endpoint to use its v2, which apparently gives better data.
The client was still using v1
💻 Examples
🚨 Test instructions
History tests should still be passing
💥 Does this PR introduce a breaking change?
The HistoryResponse class doesn't have a list of candle data, but another nested object called HistoryResponseData, which in turn holds that list. This follows the structure of the JSON returned by v2 endpoint.
✔️ PR Todo
it looks like some tests have been broken for a while, but I have unfortunately no time to fix them at present