Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privileged User Unreads #368

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Privileged User Unreads #368

merged 3 commits into from
Feb 7, 2025

Conversation

cohoe
Copy link
Member

@cohoe cohoe commented Jan 20, 2025

Should fix #216 by adding logic to make Redis notification data follow what we do in the DB for mod/tt unread messages.

Starts creating a central place to codify privileged user names since we have those strings scattered throughout the app and it's hard to remember what the values are supposed to be.

Copy link
Collaborator

@challfry challfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may come back and tinker with this later; code that currently checks against specific privileged usernames almost always either wants the UserCache entries for those users or wants to do an authorization check. Both of these use cases may be better served by adding methods to PrivilegedUser, instead of having PrivilegedUser vend out names. But we're close to boat, so--this looks fine.

@cohoe cohoe merged commit 7192245 into jocosocial:master Feb 7, 2025
3 checks passed
@cohoe cohoe deleted the unreadcount branch February 7, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderator/Twitarrteam Seamail Unread Count Incorrect
2 participants