Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CoC Markdown Formatting #377

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Conversation

cohoe
Copy link
Member

@cohoe cohoe commented Feb 2, 2025

The Tricordarr markdown renderer was struggling with the in-paragraph newlines of the Code of Conduct. Various workarounds did not improve the situation significantly. This simply "formats" the markdown to something normal. No change in content or behavior of the Swiftarr markdown renderer.

@cohoe cohoe merged commit 09b34b5 into jocosocial:master Feb 2, 2025
3 checks passed
@cohoe cohoe deleted the markdownstyle branch February 2, 2025 21:31
@challfry
Copy link
Collaborator

challfry commented Feb 3, 2025

Hmm. Paragraphs spanning multiple lines with no blank lines is one of the core features of Markdown. It's in section 4.8 of the CommonMark spec and also in the very similar Github Flavored Markdown spec. Heck, the Wikipedia page mentions this feature.

@hendricksond
Copy link
Member

Should probably be filed as a bug in whatever renderer is being used.

@cohoe
Copy link
Member Author

cohoe commented Feb 3, 2025

The React Native ecosystem around this has been surprisingly problematic. The module I'm using is a fork of a fork of an abandoned project. There are probably others out there but it's amazing how limiting this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants