Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to chart, support for custom namespace #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/cert-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ name: cert-exporter
description: Monitors and exposes PKI information as Prometheus metrics

type: application
version: 3.10.0
version: 3.10.1
appVersion: v2.14.0
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: {{ .Values.certManager.kind }}
metadata:
name: "{{- include "cert-exporter.fullname" . -}}-cert-manager"
namespace: {{ .Values.certManager.namespace }}
labels:
{{- include "cert-exporter.certManagerLabels" . | nindent 4 }}
spec:
Expand Down
1 change: 1 addition & 0 deletions helm/cert-exporter/templates/cert-manager/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "cert-exporter.fullname" . }}
namespace: {{ .Values.certManager.namespace }}
labels:
{{- include "cert-exporter.certManagerLabels" . | nindent 4 }}
{{- with .Values.service.annotations }}
Expand Down
3 changes: 2 additions & 1 deletion helm/cert-exporter/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
certManager:
# DaemonSet or Deployment
kind: Deployment
namespace: monitoring
replicaCount: 1
# Adds additional labels to pods
additionalPodLabels: {}
Expand All @@ -10,7 +11,7 @@ certManager:
image:
repository: joeelliott/cert-exporter
# The default tag is ".Chart.AppVersion", only set "tag" to override that
tag:
tag:
pullPolicy: IfNotPresent
command: ["./app"]
args:
Expand Down
Loading