Skip to content

Commit

Permalink
SKA: Relocate "platform" packages that remain on /packages (elastic…
Browse files Browse the repository at this point in the history 
…#208704)

## Summary

The `/packages` folder at the root of the Kibana repository used to
contain a lot of packages.
In the context of SKA, they have been gradually moved to various
locations:
* `src/platform/packages`
* `x-pack/platform/packages`
* `src/core/packages`

Currently, only `devOnly: true` packages are left in this folder. This
comprises libraries for CLI scripts as well as testing utilities.

With this PR, we are moving ~half of these packages under
`src/platform/packages/(private|shared)/`.
In particular, we are moving those packages that are being used from
platform and/or solutions.

Since they are `"devOnly": true`, this means they are ONLY used from
tests, cypress tests, storybook configs, ./scripts/ folders inside some
modules, or other non-prod-time logic. Nonetheless, they are effectively
referenced from platform and/or solutions code, hence I decided they
should be placed under `platform` folders.

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
@gsoldevila @kibanamachine
gsoldevila and kibanamachine authored Feb 24, 2025
1 parent 317580f commit 6a7c904
Show file tree
Hide file tree
Showing 1,447 changed files with 1,129 additions and 1,017 deletions.
28 changes: 15 additions & 13 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
if (
(await doAnyChangesMatch([
/^x-pack\/solutions\/observability\/plugins\/apm/,
/^packages\/kbn-apm-synthtrace/,
/^src\/platform\/packages\/shared\/kbn-apm-synthtrace/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
) {
Expand All @@ -102,7 +102,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
if (
(await doAnyChangesMatch([
/^x-pack\/solutions\/observability\/plugins\/inventory/,
/^packages\/kbn-apm-synthtrace/,
/^src\/platform\/packages\/shared\/kbn-apm-synthtrace/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
) {
Expand Down Expand Up @@ -236,7 +236,8 @@ const getPipeline = (filename: string, removeSteps = true) => {

if (
(await doAnyChangesMatch([
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/test\/defend_workflows_cypress/,
/^x-pack\/test\/security_solution_cypress/,
Expand All @@ -252,7 +253,8 @@ const getPipeline = (filename: string, removeSteps = true) => {
if (
(await doAnyChangesMatch([
/^package.json/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-.*/,
/^x-pack\/platform\/plugins\/shared\/alerting/,
/^x-pack\/platform\/plugins\/shared\/data_views\/common/,
/^x-pack\/solutions\/security\/plugins\/lists/,
Expand Down Expand Up @@ -297,7 +299,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^package.json/,
/^src\/platform\/packages\/shared\/kbn-discover-utils/,
/^packages\/kbn-doc-links/,
/^src\/platform\/packages\/shared\/kbn-doc-links/,
/^src\/platform\/packages\/shared\/kbn-dom-drag-drop/,
/^src\/platform\/packages\/shared\/kbn-es-query/,
/^src\/platform\/packages\/shared\/kbn-i18n/,
Expand All @@ -308,16 +310,17 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^src\/platform\/packages\/shared\/kbn-rule-data-utils/,
/^src\/platform\/packages\/shared\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-search-types/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-ecs/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-alerting-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-list-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-list-hooks/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-t-grid/,
/^src\/platform\/packages\/shared\/kbn-ui-theme/,
/^src\/platform\/packages\/shared\/kbn-utility-types/,
/^packages\/react/,
/^packages\/shared-ux/,
/^src\/platform\/packages\/shared\/react/,
/^src\/platform\/packages\/shared\/shared-ux/,
/^src\/core/,
/^src\/platform\/plugins\/shared\/charts/,
/^src\/platform\/plugins\/shared\/controls/,
Expand Down Expand Up @@ -362,7 +365,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^package.json/,
/^src\/platform\/packages\/shared\/kbn-discover-utils/,
/^packages\/kbn-doc-links/,
/^src\/platform\/packages\/shared\/kbn-doc-links/,
/^src\/platform\/packages\/shared\/kbn-dom-drag-drop/,
/^src\/platform\/packages\/shared\/kbn-es-query/,
/^src\/platform\/packages\/shared\/kbn-i18n/,
Expand All @@ -373,16 +376,15 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^src\/platform\/packages\/shared\/kbn-rule-data-utils/,
/^src\/platform\/packages\/shared\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-search-types/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-ecs/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-alerting-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-io-ts-list-types/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-list-hooks/,
/^x-pack\/solutions\/security\/packages\/kbn-securitysolution-t-grid/,
/^src\/platform\/packages\/shared\/kbn-ui-theme/,
/^src\/platform\/packages\/shared\/kbn-utility-types/,
/^packages\/react/,
/^packages\/shared-ux/,
/^src\/platform\/packages\/shared\/react/,
/^src\/platform\/packages\/shared\/shared-ux/,
/^src\/core/,
/^src\/platform\/plugins\/shared\/charts/,
/^src\/platform\/plugins\/shared\/controls/,
Expand Down Expand Up @@ -458,7 +460,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^x-pack\/platform\/plugins\/private\/discover_enhanced\/ui_tests/,
/^x-pack\/solutions\/observability\/plugins\/observability_onboarding/,
/^packages\/kbn-scout/,
/^src\/platform\/packages\/shared\/kbn-scout/,
])) ||
GITHUB_PR_LABELS.includes('ci:scout-ui-tests')
) {
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/test/jest_parallel.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ echo "+++ ⚠️ WARNING ⚠️"
echo "
console.log(), console.warn(), and console.error() output in jest tests causes a massive amount
of noise on CI without any percevable benefit, so they have been disabled. If you want to log
output in your test temporarily, you can modify 'packages/kbn-test/src/jest/setup/disable_console_logs.js'
output in your test temporarily, you can modify 'src/platform/packages/shared/kbn-test/src/jest/setup/disable_console_logs.js'
"

while read -r config; do
Expand Down
4 changes: 2 additions & 2 deletions .eslintignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ snapshots.js
/packages/kbn-eslint-config
/packages/kbn-plugin-generator/template
/packages/kbn-generate/templates
/packages/kbn-test/src/functional_test_runner/__tests__/fixtures/
/packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
/src/platform/packages/shared/kbn-test/src/functional_test_runner/__tests__/fixtures/
/src/platform/packages/shared/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
/src/platform/packages/shared/kbn-flot-charts/lib
/src/platform/packages/shared/kbn-monaco/src/**/antlr
/src/platform/packages/shared/kbn-esql-ast/src/**/antlr
Expand Down
13 changes: 7 additions & 6 deletions .eslintrc.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ module.exports = {
*/
{
files: [
'packages/kbn-ftr-common-functional-ui-services/services/web_element_wrapper/scroll_into_view_if_necessary.js',
'src/platform/packages/shared/kbn-ftr-common-functional-ui-services/services/web_element_wrapper/scroll_into_view_if_necessary.js',
'**/browser_exec_scripts/**/*.js',
],
rules: {
Expand Down Expand Up @@ -1441,13 +1441,13 @@ module.exports = {
},
{
files: [
'packages/kbn-scout/src/playwright/**/*.ts',
'src/platform/packages/shared/kbn-scout/src/playwright/**/*.ts',
'x-pack/solutions/observability/packages/kbn-scout-oblt/src/playwright/**/*.ts',
'src/platform/plugins/**/ui_tests/**/*.ts',
'x-pack/platform/plugins/**/ui_tests/**/*.ts',
'x-pack/solutions/**/plugins/**/ui_tests/**/*.ts',
],
excludedFiles: ['packages/kbn-scout/src/playwright/**/*.test.ts'],
excludedFiles: ['src/platform/packages/shared/kbn-scout/src/playwright/**/*.test.ts'],
extends: ['plugin:playwright/recommended'],
plugins: ['playwright'],
settings: {
Expand Down Expand Up @@ -1909,7 +1909,7 @@ module.exports = {
'test/interactive_setup_functional/**/*.{js,mjs,ts,tsx}',

'packages/kbn-mock-idp-plugin/**/*.{js,mjs,ts,tsx}',
'packages/kbn-mock-idp-utils/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/private/kbn-mock-idp-utils/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',

Expand Down Expand Up @@ -1995,7 +1995,7 @@ module.exports = {
'src/platform/packages/shared/kbn-config-schema',
'src/platform/plugins/shared/saved_objects_management/**',
'src/platform/packages/shared/kbn-analytics/**',
'packages/kbn-telemetry-tools/**',
'src/platform/packages/private/kbn-telemetry-tools/**',
'src/platform/plugins/private/kibana_usage_collection/**',
'src/platform/plugins/shared/usage_collection/**',
'src/platform/plugins/shared/telemetry/**',
Expand Down Expand Up @@ -2063,7 +2063,8 @@ module.exports = {
*/
{
files: [
'packages/kbn-{package-*,repo-*,dep-*}/**/*',
'src/platform/packages/*/kbn-repo-*/**/*',
'packages/kbn-repo-*/**/*',
'packages/kbn-validate-next-docs-cli/**/*',
'packages/kbn-find-used-node-modules/**/*',
],
Expand Down
Loading

0 comments on commit 6a7c904

Please sign in to comment.