Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow import of group and instance issues #3901

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cbergmann
Copy link
Contributor

Description

This allows searching and importing of gitlab issues on a group and instance level.

Issues Resolved

#2529

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@johannesjo
Copy link
Owner

johannesjo commented Jan 17, 2025

Hey there! Thank you very much for opening this up!

Could you check the linting issue?

Also: There was something similar implemented in the past, which broke the gitlab integration for a lot of people . Did you test the feature for possible side effects for different configurations?

@cbergmann
Copy link
Contributor Author

Hi,
thanks for looking over this.

The last commit fixes the linting issue.

I tested this with a Installation that was created before the patch and it seemd to be working. Then I changed the new setting and got results from other gitlab projects. I also changed it back to the default and only got the issues from the project. Any hints on what additional checks I could make are greatly welcome. While testing I also found that the link to the issue in the search result was broken and fixed that.

I think the last change that also broke it for some people was by me and you are rightfully critical of this change. But because of the new structure of the gitlab implementation this cange is a lot smaller and I think therefore better to review.

The only thing I am not sure about are automated tests. I have not yet written tests for angular.

@johannesjo
Copy link
Owner

Sorry for the delay. This slipped under my radar somehow.

I just tested it and this breaks using this with gitlab.com (leads to a 500 error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants