Fix an issue with non "image" mime types downloading with android download manager #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iJimmyWei
changed the title
|
Can we merge this PR asap? My app got thousands of crashes because of this issue |
|
Why this is not merged yet? |
* The promise fails even though the download goes through due to this explicit check not setting filePath
Dimon70007
pushed a commit
to Dimon70007/rn-fetch-blob
that referenced
this pull request
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #214 and wkh237#606
filePathwasn't being set for non image based mime types, causing download manager to throw an error, even though the file downloaded successfully