Add Sink connector format option #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move description to the correct property - Add the 2 other currently allowed values for "message.converter" property in the RabbitMQ source connector
- Before you had to use the ByteArrayConverter to use the RabbitMQ sink connector, now you can use more converters such as the avro converter and provide a formatter to convert the kafka connect agnostic format to for example json. Can be extended to avro, parquet, ... - Renamed test topic in script to "rabbitmq-test". It is discourgaged to use dots - Re-add the config directory to have a test config you can use when locally debugging with docker compose - Update readme with new option
- We have a requirement where we do not want our Rabbitmq consumers to depend on our schema registry. Instead we give them a schema they can use to deserialize the data written from a queue. - If you want confluent avro on the rabbitMq queue, you can still use the org.apache.kafka.connect.converters.ByteArrayConverter after putting confluent avro on your topic - Added unit tests for all formatters
…n one mapping for queue to topic. Before it was only possible to have a Many (queues) to One (topic) mapping in the RabbitMQSourceConnector: - Use Map to represent the queue and topic config where the old config is backwards compatible - add queue variable in ConnectConsumer. It is the only way to know from which queue it is consuming. Use a new consumer per topic
…iple tasks. When the setting "rabbitmq.queue.topic.mapping" is not present. The previous implemention is used where every task consumes all the queues.
…-single-connector Add one on one queue topic mapping single connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to add a formatter when writing data to RabbitMQ: