Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete users by alternate ids #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/braze_ruby/endpoints/delete_users.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ def delete_users(payload)
delete_users_action(external_ids: payload.compact.uniq)
end

def delete_users_by_alias(payload)
delete_users_action(user_aliases: payload.compact.uniq)
end

def delete_users_by_braze_id(payload)
delete_users_action(braze_ids: payload.compact.uniq)
end

private

def delete_users_service
Expand Down
6 changes: 4 additions & 2 deletions lib/braze_ruby/rest/delete_users.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
module BrazeRuby
module REST
class DeleteUsers < Base
def perform(external_ids: [])
def perform(external_ids: [], user_aliases: [], braze_ids: [])
http.post "/users/delete", {
external_ids: external_ids
external_ids: external_ids,
user_aliases: user_aliases,
braze_ids: braze_ids,
}
end
end
Expand Down
26 changes: 26 additions & 0 deletions spec/braze_ruby/endpoints/delete_users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,30 @@ def api_key
delete_users!
end
end

describe "#delete_users_by_alias" do
let(:payload) { [1, 2, 3] }

subject(:delete_users_by_alias!) { api.delete_users_by_alias(payload) }

it "deletes users by alias" do
expect(delete_users_service).to receive(:perform)
.with(user_aliases: payload)

delete_users_by_alias!
end
end

describe "#delete_users_by_braze_id" do
let(:payload) { [1, 2, 3] }

subject(:delete_users_by_braze_id!) { api.delete_users_by_braze_id(payload) }

it "deletes users by braze id" do
expect(delete_users_service).to receive(:perform)
.with(braze_ids: payload)

delete_users_by_braze_id!
end
end
end
8 changes: 7 additions & 1 deletion spec/braze_ruby/rest/delete_users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
describe BrazeRuby::REST::DeleteUsers do
let(:http) { double(:http) }

let(:payload) { {external_ids: [1, 2, 3]} }
let(:payload) do
{
external_ids: [1, 2, 3],
user_aliases: [4, 5, 6],
braze_ids: [7, 8, 9],
}
end

subject { described_class.new :api_key, :rest_url, {} }

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading