Clean up function definition and calling #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhogg
added
🚀 enhancement
Simplify `call_helper`; throw `CallFast` instruction.
I need a pre-commit hook to run the tests and linter...
This is a little expensive at the moment as it copies a local names stack on each function call.
…gh execution This now *requires* that the simplifier be run for function definition to work. Names external to a function are now captured at definition time, which means we need to know what those names are, and the simplifier contains the logic to do that.
Instead of each program having its own sub-program, function bodies are compiled into the program where they are defined and the `Function` object maintains a link to this program and the address that the function starts at. Necessitated adding a new `Exit` instruction to jump to the end of the program and return early.
…dule Also, rename `.graph` to `.root` while I'm at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #38