Skip to content

Commit

Permalink
Merge pull request #35 from joncloud/node-20-upgrade
Browse files Browse the repository at this point in the history
Upgrades Node to LTS
  • Loading branch information
joncloud authored Feb 6, 2024
2 parents d8082fc + 6d4b65d commit 561d768
Show file tree
Hide file tree
Showing 13 changed files with 273 additions and 564 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:16",
"image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:20",
"hostRequirements": {
"cpus": 1
},
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:

strategy:
matrix:
os: [ 'windows-latest', 'ubuntu-20.04', 'macos-latest' ]
node-version: [16.x]
os: [ 'windows-latest', 'ubuntu-latest', 'macos-latest' ]
node-version: [20.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -26,15 +26,15 @@ jobs:

- name: 'Install makensis (apt)'
run: sudo apt update && sudo apt install -y nsis nsis-pluginapi
if: ${{ matrix.os == 'ubuntu-20.04' }}
if: ${{ matrix.os == 'ubuntu-latest' }}

- name: 'Install makensis (homebrew)'
run: brew update && brew install makensis
if: ${{ matrix.os == 'macos-latest' }}

- name: 'Set Plugin permissions'
run: sudo chown -R $(whoami) /usr/share/nsis/Plugins/
if: ${{ matrix.os == 'ubuntu-20.04' }}
if: ${{ matrix.os == 'ubuntu-latest' }}

- name: 'Install npm dependencies'
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ inputs:
default: ''

runs:
using: 'node16'
using: 'node20'
main: 'dist/index.cjs'

branding:
Expand Down
8 changes: 4 additions & 4 deletions dist/index.cjs

Large diffs are not rendered by default.

Loading

0 comments on commit 561d768

Please sign in to comment.