Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize text and support group rect #42

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Optimize text and support group rect #42

merged 8 commits into from
Jan 29, 2024

Conversation

jonmmease
Copy link
Owner

@jonmmease jonmmease commented Jan 29, 2024 •
edited
Loading

This PR does a few things:

  1. It improves the performance of the text mark by sharing the FontSystem and SwashCache across marks.
  2. Fixes the coloring of emoji
  3. Sets default font families to better match vega/vl-convert
  4. Adds support for stroke/fill for group marks.
  5. Adds pixi config in preparation for Python support

Here's an example rendered by this PR:

text-emoji

jonmmease
jonmmease commented Jan 29, 2024
View reviewed changes
avenger-vega-test-data/vega-scenegraphs/text/emoji.png
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vl-convert doesn't handle emoji, so we're not actually trying to match this baseline

@jonmmease jonmmease merged commit 98dde22 into main Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonmmease