Skip to content

Commit

Permalink
fix icons not showing on blizzard frames
Browse files Browse the repository at this point in the history
fixes #655, fixes #656
  • Loading branch information
jordonwow committed Jul 19, 2023
1 parent ab1c131 commit 4dd89db
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions BigDebuffs.lua
Original file line number Diff line number Diff line change
Expand Up @@ -949,22 +949,10 @@ function BigDebuffs:AttachUnitFrame(unit)

if frame.anchor then
if frame.blizzard then
-- Blizzard Frame
if frame.anchor.SetDrawLayer then frame.anchor:SetDrawLayer("BACKGROUND") end
local parent = frame.anchor.portrait and frame.anchor.portrait:GetParent() or frame.anchor:GetParent()
frame:SetParent(parent)
if unit == "player" then
frame:SetFrameLevel(parent:GetFrameLevel() + 1)
else
frame:SetFrameLevel(parent:GetFrameLevel())
end

if frame.anchor.portrait then
frame.anchor.portrait:SetDrawLayer("BACKGROUND")
elseif frame.anchor.SetDrawLayer then
frame.anchor:SetDrawLayer("BACKGROUND")
end

frame:SetFrameLevel(parent:GetFrameLevel())

This comment has been minimized.

Copy link
@MarkusKlinder

MarkusKlinder Jul 19, 2023

I think a higher FrameLevel is needed, because without, the icons does not get displayed for me.
That way it also worked with Masque, but there is a weird blue border, but thats probaly an issue from Masque.

Original version:
Screenshot_46
frame:SetFrameLevel(parent:GetFrameLevel() + 1) version:
Screenshot_45

frame:SetFrameLevel(parent:GetFrameLevel() + 2)
places it over the floating combat text like healing received on the player frame.

Kind Regards

This comment has been minimized.

Copy link
@Ksdemonxs

Ksdemonxs Jul 19, 2023

Yeah, still not working for me aswell.

if frame.anchor.portrait then frame.anchor.portrait:SetDrawLayer("BACKGROUND", 0) end
frame.cooldown:SetSwipeTexture("Interface\\CHARACTERFRAME\\TempPortraitAlphaMaskSmall")
else
frame:SetParent(frame.parent and frame.parent or frame.anchor)
Expand Down

2 comments on commit 4dd89db

@jordonwow
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f1f5b82 addresses this, let me know if there are still issues.

@MarkusKlinder
Copy link

@MarkusKlinder MarkusKlinder commented on 4dd89db Jul 20, 2023 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.