Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ohior impl2 #31

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ohior impl2 #31

wants to merge 6 commits into from

Conversation

Ohior
Copy link

@Ohior Ohior commented Feb 24, 2025

The error you pointed out I fixed it. I use another package instead russhwolf multiplatform-settings .
I have implemented the chatting feature.
These are the view for android, desktop and web. I am working on windows so I could not test IOS. If you don't mind testing for IOS, I will be grateful

Screenshot_20250224_152649
java_uXagOSUAzG
opera_agMOP3aRpf

@joreilly
Copy link
Owner

iOS build is failing with what looks like Voyager related error. I'll try and take a look later

Compilation failed: Error occurred while optimizing an expression:
CALL 'public abstract fun <set-value> (<set-?>: T of kotlinx.coroutines.flow.MutableStateFlow): kotlin.Unit declared in kotlinx.coroutines.flow.MutableStateFlow' type=kotlin.Unit origin=EQ
  $this: CALL 'internal final fun <get-lastScreenModelKey> (): kotlinx.coroutines.flow.MutableStateFlow<kotlin.String?{ cafe.adriel.voyager.core.model.ScreenModelKey? }> declared in cafe.adriel.voyager.core.model.ScreenModelStore' type=kotlinx.coroutines.flow.MutableStateFlow<kotlin.String?{ cafe.adriel.voyager.core.model.ScreenModelKey? }> origin=GET_PROPERTY
    $this: GET_VAR 'val this: cafe.adriel.voyager.core.model.ScreenModelStore [val] declared in ui.screens.gemini_ai.GeminiAIScreen.Content' type=cafe.adriel.voyager.core.model.ScreenModelStore origin=null
  <set-?>: GET_VAR 'val key: kotlin.String{ cafe.adriel.voyager.core.model.ScreenModelKey } [val] declared in ui.screens.gemini_ai.GeminiAIScreen.Content' type=kotlin.String{ cafe.adriel.voyager.core.model.ScreenModelKey } origin=null

@Ohior
Copy link
Author

Ohior commented Feb 25, 2025

iOS build is failing with what looks like Voyager related error. I'll try and take a look later

Compilation failed: Error occurred while optimizing an expression:
CALL 'public abstract fun <set-value> (<set-?>: T of kotlinx.coroutines.flow.MutableStateFlow): kotlin.Unit declared in kotlinx.coroutines.flow.MutableStateFlow' type=kotlin.Unit origin=EQ
  $this: CALL 'internal final fun <get-lastScreenModelKey> (): kotlinx.coroutines.flow.MutableStateFlow<kotlin.String?{ cafe.adriel.voyager.core.model.ScreenModelKey? }> declared in cafe.adriel.voyager.core.model.ScreenModelStore' type=kotlinx.coroutines.flow.MutableStateFlow<kotlin.String?{ cafe.adriel.voyager.core.model.ScreenModelKey? }> origin=GET_PROPERTY
    $this: GET_VAR 'val this: cafe.adriel.voyager.core.model.ScreenModelStore [val] declared in ui.screens.gemini_ai.GeminiAIScreen.Content' type=cafe.adriel.voyager.core.model.ScreenModelStore origin=null
  <set-?>: GET_VAR 'val key: kotlin.String{ cafe.adriel.voyager.core.model.ScreenModelKey } [val] declared in ui.screens.gemini_ai.GeminiAIScreen.Content' type=kotlin.String{ cafe.adriel.voyager.core.model.ScreenModelKey } origin=null

adrielcafe/voyager#522 (comment)

@joreilly
Copy link
Owner

I updated to following here and builds/runs fine now on iOS

kotlin = "2.1.10"
kotlinx-coroutines = "1.10.1"

one other small thing....in light mode it's very hard to read the text (gray background with black text)....could you update that as well

@Ohior
Copy link
Author

Ohior commented Feb 25, 2025

I am glad that worked. I will improve the theme next

@Ohior
Copy link
Author

Ohior commented Feb 28, 2025

The UI preview, It applies to all platform

Screenshot_20250228_012525
Screenshot_20250228_114942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants