Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove undefined groundPlane #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: remove undefined groundPlane #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d15a01b
fix: body element position
hongbo-miao Mar 24, 2019
b40e76a
fix: remove undefined groundPlane
hongbo-miao Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/chapter-01/04-materials-light-animation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<!DOCTYPE html>
<html>

<body>

<head>
<title>Example 01.04 - Materials, light and animation</title>
<meta charset="UTF-8" />
Expand All @@ -15,6 +13,8 @@
<link rel="stylesheet" href="../../css/default.css">
</head>

<body>

<!-- Div which will hold the Output -->
<div id="webgl-output"></div>

Expand Down
2 changes: 1 addition & 1 deletion src/chapter-01/05-control-gui.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<!DOCTYPE html>

<html>
<body>

<head>
<title>Example 01.05 - Control gui</title>
Expand All @@ -16,6 +15,7 @@
<link rel="stylesheet" href="../../css/default.css">
</head>

<body>
<div id="webgl-output"></div>

<!-- Javascript code that runs our Three.js examples -->
Expand Down
2 changes: 0 additions & 2 deletions src/chapter-05/js/05-11.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ function init() {
// the start geometry and material. Used as the base for the settings in the control UI
this.appliedMaterial = applyMeshNormalMaterial
this.castShadow = true;
this.groundPlaneVisible = true;

this.radius = 10;
this.detail = 0;
Expand Down Expand Up @@ -74,7 +73,6 @@ function init() {
}).onChange(controls.redraw)

gui.add(controls, 'castShadow').onChange(function(e) {controls.mesh.castShadow = e})
gui.add(controls, 'groundPlaneVisible').onChange(function(e) {groundPlane.material.visible = e})

// initialize the first redraw so everything gets initialized
controls.redraw();
Expand Down
3 changes: 2 additions & 1 deletion src/chapter-09/01-basic-animation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<!DOCTYPE html>
<html>

<body>
<head>
<title>Example 09.01 - Simple animation</title>
<meta charset="UTF-8" />
Expand All @@ -16,6 +15,8 @@
<link rel="stylesheet" href="../../css/default.css">
</head>

<body>

<!-- Div which will hold the Output -->
<div id="webgl-output"></div>

Expand Down
3 changes: 2 additions & 1 deletion src/chapter-09/02-selecting-objects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<!DOCTYPE html>
<html>

<body>
<head>
<title>Example 09.02 - Selecting objects</title>
<meta charset="UTF-8" />
Expand All @@ -16,6 +15,8 @@
<link rel="stylesheet" href="../../css/default.css">
</head>

<body>

<!-- Div which will hold the Output -->
<div id="webgl-output"></div>

Expand Down