Skip to content

PR Guidlines for NodeJS Backend

Sunil Sonawane edited this page May 14, 2020 · 3 revisions

Guidlines to follow while raising PR:

  1. PR title should be valid and clear. Should not contain feature branch name.
  2. If PR is in progress keep it in draft state.
  3. Add node-backend label to PR.
  4. Assign NodeJS Backend project to PR.
  5. Add your self as an assignee (For draft PR).
  6. Add project owner as assignee (For Open PR).
  7. Add project owner as reviewer (Current project owner is Sunil Sonawane).
  8. If you have added/modified contains of .env file, sample.env file should be updated with those changes and should appear in PR.
  9. Link respective github issue to PR.
  10. If there is checklist in linked github issue, go on checking it as you complete particular subtask.
  11. If you think PR is ready for review, then get it to open state from draft state and assign it to poject owner (Remove yourself from assignee).
  12. Make sure all your subtasks of linked github issue are check marked indicating subtask completion before you take PR to open state.
  13. Once comments are made and changes are requested, add wip label to your PR when you start working on comments.
  14. Comments can be marked resolved only by project owner.
  15. Once you are done with resolving comments, remove wip label and re-request for review.

Note: Any PR not adhere to these guidlines will be rejected.