-
Notifications
You must be signed in to change notification settings - Fork 7
PR Guidlines for NodeJS Backend
Sunil Sonawane edited this page May 14, 2020
·
3 revisions
- PR title should be valid and clear. Should not contain feature branch name.
- If PR is in progress keep it in draft state.
- Add
node-backend
label to PR. - Assign
NodeJS Backend
project to PR. - Add your self as an assignee (For draft PR).
- Add project owner as assignee (For Open PR).
- Add project owner as reviewer (Current project owner is Sunil Sonawane).
- If you have added/modified contains of
.env
file,sample.env
file should be updated with those changes and should appear in PR. - Link respective github issue to PR.
- If there is checklist in linked github issue, go on checking it as you complete particular subtask.
- If you think PR is ready for review, then get it to open state from draft state and assign it to poject owner (Remove yourself from assignee).
- Make sure all your subtasks of linked github issue are check marked indicating subtask completion before you take PR to open state.
- Once comments are made and changes are requested, add
wip
label to your PR when you start working on comments. - Comments can be marked resolved only by project owner.
- Once you are done with resolving comments, remove
wip
label and re-request for review.
Note: Any PR not adhere to these guidlines will be rejected.
Copyright © Josh Software Pvt. Ltd.