Add -L option to list open CRs

CHANGES.md

@@ -2,6 +2,15 @@
 
 ## not yet released
 
+## 1.8.0
+
+- grr -r <cr|ia> support to vote on Code-Review or Integration-Approval
+  on projects
+
+## 1.7.0
+
+- grr -L support to list outstanding reviews for this project
+
 ## 1.6.0
 
 - Update grr to use the new https://jira.joyent.us

lib/cli.js

@@ -5,7 +5,7 @@
  */
 
 /*
- * Copyright 2016 Joyent, Inc.
+ * Copyright 2018 Joyent, Inc.
  */
 
 /*
@@ -21,6 +21,9 @@ var VError = require('verror').VError;
 var grr = require('./grr');
 var pkg = require('../package.json');
 
+var VALID_REVIEWS = {
+    'cr': 'Code-Review',
+    'ia': 'Integration-Approval'};
 
 // ---- globals and constants
 
@@ -49,18 +52,28 @@ var options = [
     {
         group: 'For creating/updating CRs'
     },
-    //{
-    //    names: ['dry-run', 'n'],
-    //    type: 'bool',
-    //    help: 'Go through the motions without actually commiting or pushing.',
-    //    'default': false
-    //},
+    {
+        names: ['dry-run', 'n'],
+        type: 'bool',
+        help: 'Go through the motions without actually commiting, pushing or'
+            + ' reviewing.',
+        'default': false
+    },
     {
         names: ['parenthetical', 'p'],
         type: 'string',
         help: 'Add a parenthetical comment to the commit message. Typically '
             + 'used for followup commits on an issue already commited to.'
     },
+    {
+        names: ['review', 'r'],
+        type: 'string',
+        help: 'Add either "cr" or "ia" +1s to any matching issues.'
+    },
+    {   names: ['diff', 'd'],
+        type: 'bool',
+        help: 'When using -r, show the latest diffs of reviews.'
+    },
     {
         names: ['update', 'u'],
         type: 'bool',
@@ -83,6 +96,14 @@ var options = [
         type: 'bool',
         help: 'Delete the local branch used for working with the CR. '
             + 'Typically this is used when you are done with the CR.'
+    },
+    {
+        group: 'Miscellaneous CR operations'
+    },
+    {
+        names: ['list', 'L'],
+        type: 'bool',
+        help: 'List outstanding code reviews for this component.'
     }
 ];
 
@@ -101,6 +122,8 @@ function usage() {
         'Usage:',
         '    grr [<options>] [<issue>]  # create or update a CR',
         '    grr -D [<issue>]           # delete feature branch, switch to master',
+        '    grr -L                     # list outstanding CRs for this component.',
+        '    grr -r [cr|ia] <issue>     # add CR or IA +1s to matching issues.',
         '',
         'Options:',
         help,
@@ -112,7 +135,8 @@ function usage() {
         '    grr TOOLS-123    # Start or update a branch and CR for this ticket',
         //'    grr --commit TOOLS-123    # ... also commit uncommited changes',
         '    grr              # Update the current CR (using the cached ticket)',
-        '    grr -D           # All done. Del the branch and switch back to master'
+        '    grr -D           # All done. Del the branch and switch back to master',
+        '    grr -r cr [-d] TOOLS-123  # Add +1 CRs for TOOLS-123 tickets'
     ].join('\n'));
     /* END JSSTYLED */
 }
@@ -179,6 +203,20 @@ function main(argv) {
             issueArg: issueArg,
             dryRun: opts.dry_run
         }, mainFinish);
+    } else if (opts['list']) {
+        grr.grrList({log: log}, mainFinish);
+    } else if (opts['review']) {
+        if (!VALID_REVIEWS.hasOwnProperty(opts['review'])) {
+            console.error('grr: unknown review type');
+            process.exit(1);
+        }
+        grr.grrReview({
+            log: log,
+            issueArg: issueArg,
+            dryRun: opts.dry_run,
+            reviewArg: VALID_REVIEWS[opts.review],
+            diffArg: opts.diff,
+            verbose: opts.verbose}, mainFinish);
     } else {
         grr.grrUpdateOrCreate({
             log: log,