Fix Dialog background scroll #3907
Conversation
🦋 Changeset detectedLatest commit: 7d5d6f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@liamsms is attempting to deploy a commit to the FED Team Team on Vercel. A member of the Team first needs to authorize it. |
|
this change should probably be built as a prop in |
Hi - I've updated this to be a prop |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshwooding
dismissed stale reviews from tayyabataimur and Fercas123
via
4230eaf
joshwooding
force-pushed
the
fix-dialog-scroll
branch
from
4230eaf to
8a7b587
Compare
joshwooding
force-pushed
the
fix-dialog-scroll
branch
from
8a7b587 to
7d5d6f8
Compare
| /** | ||
| * Disables scrolling the document body while the floating component is open. | ||
| */ | ||
| disableScroll?: boolean; |
There was a problem hiding this comment.
We should check if we're happy with the naming here
There was a problem hiding this comment.
There was a problem hiding this comment.
I think the choices are: lockScroll, preventScroll or disableScroll
There was a problem hiding this comment.
lockScroll is consistent with Floating UI's terminology but will it be intuitive for our users, and be consistent in naming with other components in Salt?
Closes #3906
Added
disableScrollprop to FloatingComponent, which sets the document body overflow tohiddento prevent background scrolling.