Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 share results measurement bug #728

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Fix IPv6 share results measurement bug #728

merged 3 commits into from
Feb 8, 2025

Conversation

xbpcb
Copy link
Collaborator

@xbpcb xbpcb commented Feb 7, 2025 •
edited
Loading

Fix #725

Also, found another bug.
Bug description:

  1. Set measurement type to DNS
  2. Set target to some invalid value (not a domain name, IPv6 address for example)
  3. Run measurement and get an error
  4. Switch measurement type to Ping/HTTP/etc.
  5. The IP type switch no longer appears
    Fixed.

@xbpcb xbpcb requested a review from MartinKolarik February 7, 2025 16:09
@xbpcb xbpcb self-assigned this Feb 7, 2025
@MartinKolarik MartinKolarik temporarily deployed to gh-725 - globalping.io PR #728 February 7, 2025 16:10 — with Render Destroyed
@jimaek jimaek temporarily deployed to gh-725 - www.jsdelivr.com PR #728 February 7, 2025 16:10 — with Render Destroyed
@MartinKolarik MartinKolarik merged commit 088d5f6 into master Feb 8, 2025
1 check passed
@MartinKolarik MartinKolarik deleted the gh-725 branch February 8, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKolarik MartinKolarik Awaiting requested review from MartinKolarik

Assignees

@xbpcb xbpcb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"measurementOptions.ipVersion" is not allowed when target is not a domain
3 participants
@xbpcb @jimaek @MartinKolarik