A Session's channel is now able to be retrieved correctly. (Related to #57) #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly defined _getChannel method for Session ClassObjects. Should allow recording/playback to work appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull / merge request is related to the an issue described in #57. (It probably deserves it's own GitHub Issue itself.) Playback of mouse events was being entirely prevented due to Session ClassObjects being unable to retrieve channels for a peer. An error was reported on Line 155 in playback.js whenever the system tried to replay a mouse event. I tested this in both Chrome and Firefox.
I supplied a fix by explicitly defining the
_getChannelmethod for Session ClassObjects (in session.js). As I'm far less familiar with the codebase, there is probably a more elegant solution. Nevertheless, this fix does restore functionality for playing back mouse events.If you have any questions, please feel free to get back to me here. Looking forward to contributing more!