Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ubuntu:23.04 as base image #10

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alambike
Copy link

  • Use ubuntu:23.04 as base image, as its the minimum image with upbound 1.14.
  • Reconfigure unboundtest to b able to use unbound.conf from /etc/unbound

…e able to use unbound.conf from /etc/unbound
@jsha
Copy link
Owner

jsha commented Jul 12, 2023

Sweet, thanks for the fix! I was actually just working on updating the Dockerfile to use 23.04 (lunar).

I'm not so sure about the other changes. Why pull from /etc/unbound? For local dev outside a container I've found it convenient to pull from a file in the current directory. Similarly, why run as root? I'd actually love for this to be able to run in a rootless Docker setup.

Also, the diff to remove IPv6 support is incorrect for this repository's intended use.

Out of curiosity, can I ask what you're using this code for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants