Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Custom themes as option #1260

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Custom themes as option #1260

wants to merge 1 commit into from

Conversation

JoiNNN
Copy link
Contributor

@JoiNNN JoiNNN commented Jan 6, 2017

As suggested in #1258

@jshackles
Copy link
Owner

The reason I hesitate on this is that I'm torn between user choice and splitting the user base. As it is now, when someone sets their custom profile style/background, they can expect that other Enhanced Steam users will see these changes. If there is an option to disable seeing other users custom themes, it will fall into the categories of "Not using Enhanced Steam / Using Enhanced Steam with option turned on / Using Enhanced Steam with option turned off".

The better solution would be to perhaps update the clear theme (which is, I believe, the source of this issue) so that the user's header text stands out more.

@JoiNNN
Copy link
Contributor Author

JoiNNN commented Jan 17, 2017

I get your point. The reason I jumped on adding the option short after it was suggested is because I happened to came across the same issue in the past. Custom themes will be enabled by default anyway, and unless a user get bothered by those he won't look into disabling them, that's why I think is good to have the option.
We could allow the users to toggle custom themes but let them to make use of custom themes for their own profiles only if they enable the visibility of custom themes for other's profiles too.

Anyway, just my thoughts. Whatever you decide I'm OK with it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants