Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Fixed missing US price by getting country code from inline script #983

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ccloli
Copy link
Contributor

@ccloli ccloli commented Apr 1, 2016

This should fix #939.

Sometimes both steamCC... and steamCountry are not defined in cookie, so the country code is always us.

Here is a solution that mentioned in #939L3. We can get country code from g_oSuggestParams.cc, but sometimes it's not defined. It's defined after an inline script executed, so we can match CC from the inline script.

BTW, from my test, this PR has no conflicts with PR #982, so both of them can be merged safely.

US price shows successfully

@JoiNNN
Copy link
Contributor

JoiNNN commented Apr 2, 2016

Hi ccloli, region price issue is most likely fixed by #973.

@ccloli
Copy link
Contributor Author

ccloli commented Apr 2, 2016

Tested and confirmed that it also works for me. Seems that after requested //store.steampowered.com/steamaccount/addfunds, steamCountry will be added to cookies.

@fireattack
Copy link

fireattack commented May 11, 2016

@JoiNNN @ccloli It's not fixed here by #973. The US pricing is still missing here:

image

I assume the newest release version 8.4 should already include #973, since it's merged on April 3 and 8.4 released on April 6.

@ccloli
Copy link
Contributor Author

ccloli commented May 13, 2016

Screenshot
@fireattack Interesting, it's also not working for me now, with latest 8.4.

A temporary way to fix is go to http://store.steampowered.com/steamaccount/addfunds by yourself, after requested it, a cookie named steamCountry will be added, then you can see the USD.

I merged branch patch-1, patch-2 and latest version (build 8.4, means jshackles/Enhanced_Steam/master) into branch patch-test, and it looks fine for me. You can also try git clone / download it as a Zip file and unpack, load it as developing extension in chrome://extensions and have a try.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants