replace mocha and nyc with native node test runner and c8
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
force-pushed
the
node-test-runner
branch
from
5aaf5ef to
20df3ec
Compare
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
Phillip9587
force-pushed
the
node-test-runner
branch
from
20df3ec to
e0c2936
Compare
wesleytodd
approved these changes
Jan 23, 2025
Open
|
relevant express team discussion on the topic of the node test runner, and test runners in general: https://openjs-foundation.slack.com/archives/C02QB1731FH/p1729689394701019 |
bjohansebas
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
+1 on trying it in a single package for now, probably before releasing, the captain should agree, which in this case is @blakeembrey
UlisesGascon
approved these changes
Feb 4, 2025
Phillip9587
force-pushed
the
node-test-runner
branch
from
e0c2936 to
ad7b5ad
Compare
|
@UlisesGascon Done! |
UlisesGascon
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the test setup by replacing Mocha and NYC with Node.js's native test runner (
node:test) andc8for coverage reporting.Key Changes:
c8for code coverage.deep-equalwith nativeassert.deepEqual.Benefits:
These changes modernize the testing framework, reduce external dependencies, and uphold code coverage standards using built-in Node.js capabilities.