Fixes to the TD-50X schema (mostly from inaccurate documentation)

jskeet · Nov 12, 2021 · 23e5b15 · 23e5b15
1 parent 8756806
commit 23e5b15
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 6 deletions.
diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50/Physical/KitPadCommon.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50/Physical/KitPadCommon.json
@@ -189,6 +189,7 @@
     {
       "description": "Multi FX Assign",
       "type": "enum",
+      "min": 1,
       "values": [
         "MFX1",
         "MFX2",

diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50X/InstrumentGroups.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50X/InstrumentGroups.json
@@ -562,7 +562,7 @@
   },
   {
     "description": "Hi-Hat Fixed Elec",
-    "veditCategory": "HiHat",
+    "veditCategory": "Other",
     "instruments": {
       "465": "TR-808 HH Close",
       "466": "TR-808 HH Open",

diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50X/Physical/KitRoom.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50X/Physical/KitRoom.json
@@ -52,6 +52,12 @@
                   "Stage 2",
                   "Stage 3",
                   "Stage 4",
+                  // Note: small hall values aren't in the MIDI implementation document,
+                  // but are in the data list. The range is actually 0-23.
+                  "Small Hall 1",
+                  "Small Hall 2",
+                  "Small Hall 3",
+                  "Small Hall 4",
                   "Middle Hall 1",
                   "Middle Hall 2",
                   "Middle Hall 3",

diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50X/Physical/KitUnitCommon.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50X/Physical/KitUnitCommon.json
@@ -177,6 +177,7 @@
     {
       "description": "Multi FX Assign",
       "type": "enum",
+      "min": 1,
       "values": [
         "MFX1",
         "MFX2",

diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50X/VEdit/Snare.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50X/VEdit/Snare.json
@@ -25,6 +25,8 @@
     {
       "description": "Strainer adjust",
       "type": "enum16",
+      // Note: this minimum contradicts the documentation, but appears to be correct.
+      "min": 1,
       "values": [
         "Loose 1",
         "Loose 2",
@@ -67,10 +69,9 @@
       "description": "Wire level",
       "type": "range16",
       // Documentation claims -6 to +6, but over a range of 1-12.
-      // We'll assume it's actually -5 to +6, as that matches
-      // the TD-27's -4 to +5.
-      // TODO: Ask someone to validate this.
-      "min": 1,
+      // For now we'll assume it's actually -6 to +6, given that
+      // we've seen a raw value of 0 in reality.
+      "min": 0,
       "max": 12,
       "valueOffset": -6,
       "default": 6

diff --git a/Drums/VDrumExplorer.Model/SchemaResources/TD50X/VEdit/XStick.json b/Drums/VDrumExplorer.Model/SchemaResources/TD50X/VEdit/XStick.json
@@ -25,6 +25,8 @@
     {
       "description": "Strainer adjust",
       "type": "enum16",
+      // Note: this minimum contradicts the documentation, but appears to be correct.
+      "min": 1,
       "values": [
         "Loose 1",
         "Loose 2",
@@ -57,7 +59,10 @@
     {
       "description": "Wire level",
       "type": "range16",
-      "min": 1,
+      // Documentation claims -6 to +6, but over a range of 1-12.
+      // For now we'll assume it's actually -6 to +6, given that
+      // we've seen a raw value of 0 in reality.
+      "min": 0,
       "max": 12,
       "valueOffset": -6,
       "default": 6