-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -Wno-narrowing to compiler flags #15
Conversation
what is the error you are seeing ... and on what platform ? @craig-day any opinion on this ? |
It seems this is caused by a regression in gcc 5 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65801) where it won't narrow signed integers to unsigned integers. Apparently this was fixed but it is unclear to me in which version.
Output
|
It is also necessary in the cld2 version of the gem. What was done there was to set the C++ version which also lets the compiler ignore these. BanjoInc#4 |
so what approach do you prefer ?
any idea how to make the tests run ?
…On Mon, Nov 19, 2018 at 11:27 AM Craig Day ***@***.***> wrote:
It is also necessary in the cld2 version of the gem. What was done there
was to set the C++ version which also lets the compiler ignore these.
BanjoInc#4 <BanjoInc#4>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ54yI-mGQE5T64UvhCXIEksLcpTmks5uwwYvgaJpZM4YowVb>
.
|
0.8.0 is out ... idk if that will work ... if it does not, I'll just yank it and wait for anyone to fix the tests 🤷♂️ |
I can't get this to compile otherwise.