Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-formatting of CMake files. #754

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix auto-formatting of CMake files. #754

merged 2 commits into from
Nov 22, 2023

Conversation

jtv
Copy link
Owner

@jtv jtv commented Nov 22, 2023

Three changes, really:

  1. Call the CMake-file-formatting tool on *.cmake files, not on CMakeLists.txt files.
  2. Change formatting of generated CMake config to a format that won't get re-formatted after autogen.sh runs.
  3. Fix a silly typo in a comment.

jtv added 2 commits November 22, 2023 02:48
@jtv
Fix formatting of CMake files.
977f345 
The formatting tool _doesn't_ handle `CMakeLists.txt` files, only the
`*.cmake` files!

Unfortunately this also involves updating the script that generates
checks for the CMake config so as to try and avoid formatting changes.
I have a feeling I may have to complicate the script for this.
@jtv
Propagate changes.
56353bc
@jtv jtv merged commit a636141 into master Nov 22, 2023
3 checks passed
@jtv jtv deleted the format-cmake branch November 22, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtv