delint

dns/zone.py

@@ -155,24 +155,24 @@ def __iter__(self):
 
     def iterkeys(self):
         if PY3:
-            return self.nodes.keys()
+            return self.nodes.keys() # pylint: disable=dict-keys-not-iterating
         else:
             return self.nodes.iterkeys()  # pylint: disable=dict-iter-method
 
     def keys(self):
-        return self.nodes.keys()
+        return self.nodes.keys() # pylint: disable=dict-keys-not-iterating
 
     def itervalues(self):
         if PY3:
-            return self.nodes.values()
+            return self.nodes.values() # pylint: disable=dict-values-not-iterating
         else:
             return self.nodes.itervalues()  # pylint: disable=dict-iter-method
 
     def values(self):
-        return self.nodes.values()
+        return self.nodes.values() # pylint: disable=dict-values-not-iterating
 
     def items(self):
-        return self.nodes.items()
+        return self.nodes.items() # pylint: disable=dict-items-not-iterating
 
     iteritems = items
 

examples/reverse.py

@@ -34,9 +34,7 @@
         except KeyError:
             reverse_map[rdata.address] = [name.to_text()]
 
-keys = reverse_map.keys()
-keys.sort(key=dns.ipv4.inet_aton)
-for k in keys:
+for k in sorted(reverse_map.keys(), key=dns.ipv4.inet_aton):
     v = reverse_map[k]
     v.sort()
     print(k, v)

examples/xfr.py

@@ -10,7 +10,5 @@
 master_answer = dns.resolver.query(soa_answer[0].mname, 'A')
 
 z = dns.zone.from_xfr(dns.query.xfr(master_answer[0].address, 'dnspython.org'))
-names = z.nodes.keys()
-names.sort()
-for n in names:
+for n in sorted(z.nodes.keys()):
     print(z[n].to_text(n))

pylintrc

@@ -40,6 +40,7 @@ disable=
     wrong-import-position,
     len-as-condition,
     eq-without-hash,
+    next-method-defined,
 
 [REPORTS]