Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config generate in upgrade #1258

Merged
merged 7 commits into from
Feb 7, 2025
Merged

fix config generate in upgrade #1258

merged 7 commits into from
Feb 7, 2025
+750 −532

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Jan 26, 2025 •
edited
Loading

fix #1257

  1. refactor: parse settings in one function
  2. regenerate settings: if pv/pvc/secret can be fetched, use parseSetting as publishVolume does.

@zwwhdls zwwhdls requested a review from zxh326 February 5, 2025 10:03
zxh326
zxh326 reviewed Feb 6, 2025
View reviewed changes
pkg/config/command.go Outdated Show resolved Hide resolved
@zwwhdls
fix review
357ec6e 
Signed-off-by: zwwhdls <[email protected]>
@zwwhdls zwwhdls merged commit 671943b into master Feb 7, 2025
24 checks passed
@zwwhdls zwwhdls deleted the fix/update_config branch February 7, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxh326 zxh326 zxh326 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] csi 升级配置修改兼容性问题
2 participants
@zwwhdls @zxh326