Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use member initializer in the move constructor of Any #77

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 2, 2024

Description

Use member initializer.

By the way: having the following move constructor:

Any(const jule::Any &&src)

does not make much sense. The standard signature should be:

Any(jule::Any &&src)

I will change it in another PR.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

@mertcandav mertcandav self-requested a review February 2, 2024 19:30
@mertcandav mertcandav added the api About API (C++ API, not std/runtime API implementation) label Feb 2, 2024
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge your PR after your draft done.
Thanks for your contribution.

@vil02
Copy link
Contributor Author

vil02 commented Feb 2, 2024

LGTM. I will merge your PR after your draft done. Thanks for your contribution.

I just want to make sure that all of the checks pass.

@vil02 vil02 marked this pull request as ready for review February 2, 2024 19:34
@mertcandav mertcandav merged commit 0019c5a into julelang:master Feb 2, 2024
8 checks passed
@vil02 vil02 deleted the use_member_initializer_in_any branch February 2, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About API (C++ API, not std/runtime API implementation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants