Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change generics on ExpectedException.expectCause(). #1397

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Change generics on ExpectedException.expectCause(). #1397

merged 1 commit into from
Dec 1, 2016

Conversation

kcooney
Copy link
Member

@kcooney kcooney commented Nov 30, 2016

The previous generics (Matcher<? extends Throwable>) would not allow
you do use matchers on Object, like notNullValue().

Fixes #1073

@kcooney
Change generics on ExpectedException.expectCause().
dd00545 
The previous generics (Matcher<? extends Throwable>) would not allow
you do use matchers on Object, like notNullValue().

Fixes junit-team#1073
@kcooney kcooney added the 4.13 label Nov 30, 2016
@stefanbirkner stefanbirkner merged commit 44cd8f8 into junit-team:master Dec 1, 2016
@stefanbirkner
Copy link
Contributor

Thanks. Could you add this to the release notes, please.

@kcooney
Copy link
Member Author

kcooney commented Dec 2, 2016

I updated the release notes.

@kcooney kcooney deleted the expectCause-generics branch January 6, 2017 17:14
@kcooney kcooney modified the milestone: 4.13 Aug 6, 2017
@kcooney kcooney removed the 4.13 label Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13-beta-1
Development

Successfully merging this pull request may close these issues.
2 participants
@kcooney @stefanbirkner