Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ServerApp.ip is ipv6 use [::1] as local_url #1495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

If ServerApp.ip is ipv6 use [::1] as local_url #1495

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6880f01
If ServerApp.ip is ipv6 use [::1] as local_url
manics Jan 26, 2025
204ce75
Use ternary for ipv4/ipv6 output
manics Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion jupyter_server/serverapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2377,7 +2377,11 @@ def local_url(self) -> str:
parts = self._get_urlparts(include_token=True)
# Update with custom pieces.
if not self.sock:
parts = parts._replace(netloc=f"127.0.0.1:{self.port}")
if ":" in self.ip:
localhost = "[::1]"
else:
localhost = "127.0.0.1"
manics marked this conversation as resolved.
Show resolved Hide resolved
parts = parts._replace(netloc=f"{localhost}:{self.port}")
return parts.geturl()

@property
Expand Down
Loading