Handle value uses publish execution result #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainfrancois
commented
Nov 9, 2023
romainfrancois
commented
Nov 9, 2023
| if (isTRUE(last_visible)) { | ||
| obj <- .Last.value | ||
|
|
||
| mimetypes <- if (getOption('jupyter.rich_display')) { |
There was a problem hiding this comment.
perhaps this should only be text/plain. I need to look how things are done e.g in 🐍
romainfrancois
force-pushed
the
handle_value_publish_execution_result
branch
from
e3f015e to
ed7c1be
Compare
|
This can be followed up, but the idea of the pull request is that only the last expression is being auto-printed, and goes through
closes #33 |
|
This needs some follow up to handle html widgets, but I'll open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
display()which has to be called explicitly