WIP: Entrypoint configurable #509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to reuse it
Avoid duplication in documentation
manics
force-pushed
the
entrypoint_configurable
branch
from
297eda5
to
89edf8c
Compare
This means a custom proxy can be installed, and configured using traitlets in a standard jupyter_server_config file
manics
force-pushed
the
entrypoint_configurable
branch
from
3c9a00b
to
58e5667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means a custom proxy can be installed, and configured using traitlets in a standard jupyter_server_config file.
For example, it should mean (though needs to be tested) that instead of setting a env-var in jupyterhub/jupyter-remote-desktop-proxy#134 we could set
c.JupyterRemoteDesktopProxy.xstartup = ...This is just a single commit 58e5667
on top of #508 (which is on top of #507)