Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written up the Breaking changes and Deprecation headings manually, the rest is automated.
Before merge and release, I'd like to:
tls_kwargs
config to configure underlying ldap3 package tls #273resolve_username
function #274search_filter
andattributes
and improve logging forsearch_filter
#275I've requested review already though to focus on the Breaking changes and Deprecation headings as well as get a go-ahead for cutting 2.0.0b1.