Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates binderhub chart to 1.0.0-0.dev.git.3673.h040c9bbe #3156

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

jupyterhub-bot
Copy link
Collaborator

@jupyterhub-bot jupyterhub-bot commented Jan 7, 2025

Updates mybinder to depend on the binderhub chart version 1.0.0-0.dev.git.3673.h040c9bbe from version 1.0.0-0.dev.git.3548.h83da55db.

  Before After
Chart.yaml's version 1.0.0-0.dev.git.3548.h83da55db 1.0.0-0.dev.git.3673.h040c9bbe
Chart.yaml's appVersion null null

PRs

125 commits between 83da55db and 040c9bbe, not searching for PRs

jupyterhub/binderhub@83da55d...040c9bb

Related

@jupyterhub-bot jupyterhub-bot added dependencies Pull requests that update a dependency file maintenance labels Jan 7, 2025
@manics
Copy link
Member

manics commented Jan 7, 2025

This requires changes to our tests or it'll fail to deploy, see the description of
#3154

@jupyterhub-bot jupyterhub-bot force-pushed the update-chart-binderhub branch from cf43f06 to b6796e3 Compare January 8, 2025 05:03
@jupyterhub-bot jupyterhub-bot changed the title Updates binderhub chart to 1.0.0-0.dev.git.3653.hb72cd888 Updates binderhub chart to 1.0.0-0.dev.git.3656.hf9d5740a Jan 8, 2025
@jupyterhub-bot jupyterhub-bot force-pushed the update-chart-binderhub branch 3 times, most recently from 71c8f25 to 9c50831 Compare January 15, 2025 05:03
@jupyterhub-bot jupyterhub-bot changed the title Updates binderhub chart to 1.0.0-0.dev.git.3656.hf9d5740a Updates binderhub chart to 1.0.0-0.dev.git.3663.h41a95ee2 Jan 15, 2025
@jupyterhub-bot jupyterhub-bot changed the title Updates binderhub chart to 1.0.0-0.dev.git.3663.h41a95ee2 Updates binderhub chart to 1.0.0-0.dev.git.3667.h65f807c1 Jan 16, 2025
@jupyterhub-bot jupyterhub-bot force-pushed the update-chart-binderhub branch 3 times, most recently from 9529c94 to 842e4f2 Compare January 23, 2025 05:03
@jupyterhub-bot jupyterhub-bot changed the title Updates binderhub chart to 1.0.0-0.dev.git.3667.h65f807c1 Updates binderhub chart to 1.0.0-0.dev.git.3673.h040c9bbe Jan 24, 2025
@manics
Copy link
Member

manics commented Jan 24, 2025

#3189 failed on staging:
https://github.com/jupyterhub/mybinder.org-deploy/actions/runs/12947617899/job/36116473982
presumably because it's coupled to this PR. If it's working merging this PR should now pass on staging.

@manics
Copy link
Member

manics commented Jan 24, 2025

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator Author

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator Author

Job status: success
Branch 'test-this-pr/3156' has been deleted

@manics
Copy link
Member

manics commented Jan 24, 2025

The donate button needs a fix
image

@rgaiacs
Copy link
Collaborator

rgaiacs commented Jan 24, 2025

@manics where did you get the screenshot from? My understanding is that the button is defined in

banner_message: |
<a class="btn" style="width:fit-content;height:fit-content;padding:10px;background-color:#e66581;color:white;font-weight:bold;position:absolute;top:0px;bottom:0px;margin:auto 0;right:4px;"
onmouseover="this.style.backgroundColor='#d15b75'" onmouseout="this.style.backgroundColor='#e66581'"
href="https://jupyter.org/about#donate" target="_blank">
🤍 Donate to mybinder.org!
</a>
<div style="text-align:center;">
Thanks to <a href="https://www.ovh.com/">OVH</a>, <a href="https://notebooks.gesis.org">GESIS Notebooks</a> and <a href="https://2i2c.org">2i2c</a> for supporting us! 🎉
</div>
<div style="text-align:center;">
mybinder.org has updated the base image to Ubuntu 22.04! See the <a href="https://repo2docker.readthedocs.io/en/latest/howto/breaking_changes.html">upgrade guide</a> for details.
</div>
about_message: |
<p>mybinder.org is public infrastructure operated by the <a href="https://jupyterhub-team-compass.readthedocs.io/en/latest/team.html#binder-team">Binder Project team</a>.<br /><br />
The Binder Project is a member of <a href="https://jupyter.org">Project Jupyter</a>.
Donations are managed by <a href="https://lf-charities.org">LF Charities</a>, a US 501c3 non-profit.<br /><br />
For abuse please email: <a href="mailto:[email protected]">[email protected]</a>, to report a
security vulnerability please see: <a href="https://mybinder.readthedocs.io/en/latest/faq.html#where-can-i-report-a-security-issue">Where can I report a security issue</a><br /><br />
For more information about the Binder Project, see <a href="https://mybinder.readthedocs.io/en/latest/about.html">the About Binder page</a></p>

@minrk
Copy link
Member

minrk commented Jan 24, 2025

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator Author

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

bottom:0px was floating in the middle of the screen
@jupyterhub-bot
Copy link
Collaborator Author

Job status: success
Branch 'test-this-pr/3156' has been deleted

@minrk
Copy link
Member

minrk commented Jan 24, 2025

/test-this-pr

@jupyterhub-bot
Copy link
Collaborator Author

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@jupyterhub-bot
Copy link
Collaborator Author

Job status: success
Branch 'test-this-pr/3156' has been deleted

@minrk
Copy link
Member

minrk commented Jan 24, 2025

Donate button looks right now:

Screenshot 2025-01-24 at 15 20 15

Going to give this a try!

FWIW, when the connection is lost, our event stream error message is now slightly different:

Error in event stream: TypeError: Load failed

I don't remember exactly what the wording was before.

This is not a regression, but something we can still improve in a later PR. I encountered this because I was messing around with the page watching a build while a new deploy was running. When the BinderHub server restarts, users see this message and it's very unclear that what they probably need to do is just reconnect (refresh the page).

@minrk minrk merged commit ba5ad8c into main Jan 24, 2025
7 checks passed
@minrk minrk deleted the update-chart-binderhub branch January 24, 2025 14:23
@minrk
Copy link
Member

minrk commented Jan 24, 2025

needed to restart prod-deploy which failed the first time because the proxied hetzner-2i2c hadn't yet deployed the updated template when the prod test ran. This shouldn't happen often.

@minrk
Copy link
Member

minrk commented Jan 24, 2025

@rgaiacs you're right. The screenshot I assume is from staging.mybinder.org. We can test deploying changes only to staging with the "test this pr" comments, then check staging by hand to make sure everything's working before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants