-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates binderhub chart to 1.0.0-0.dev.git.3673.h040c9bbe #3156
Conversation
This requires changes to our tests or it'll fail to deploy, see the description of |
cf43f06
to
b6796e3
Compare
71c8f25
to
9c50831
Compare
9c50831
to
61dbdd4
Compare
9529c94
to
842e4f2
Compare
842e4f2
to
3d80233
Compare
#3189 failed on staging: |
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
Job status: success |
@manics where did you get the screenshot from? My understanding is that the button is defined in mybinder.org-deploy/mybinder/values.yaml Lines 174 to 192 in c46ce00
|
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
bottom:0px was floating in the middle of the screen
Job status: success |
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
Job status: success |
needed to restart prod-deploy which failed the first time because the proxied hetzner-2i2c hadn't yet deployed the updated template when the |
@rgaiacs you're right. The screenshot I assume is from staging.mybinder.org. We can test deploying changes only to staging with the "test this pr" comments, then check staging by hand to make sure everything's working before merging. |
Updates mybinder to depend on the binderhub chart version
1.0.0-0.dev.git.3673.h040c9bbe
from version1.0.0-0.dev.git.3548.h83da55db
.1.0.0-0.dev.git.3548.h83da55db
1.0.0-0.dev.git.3673.h040c9bbe
null
null
PRs
125 commits between 83da55db and 040c9bbe, not searching for PRs
jupyterhub/binderhub@83da55d...040c9bb
Related