Use French region names when finding French subdivisions + bump to version 5.2.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a French region name is found for a text related to the France country, then the department of the regional prefecture is returned as the matching subdivision. This works with old (pre-2016) and new (post-2016) region names, with a special case for the old region name "Centre", which is not used to avoid false postives (with, e.g., "Centre Pompidou"). To match this old region name, there must be "region centre" or "conseil regional centre" in the input text.
mmoriniere
force-pushed
the
mm-fr-regions
branch
from
00b8a5a
to
2840ce2
Compare
mmoriniere
changed the title
roxanebellot
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version to 5.2.0
Use French region names when finding French subdivisions
If a French region name is found for a text related to the France country, then the department of the regional prefecture is returned as the matching subdivision.
This works with old (pre-2016) and new (post-2016) region names, with a special case for the old region name "Centre", which is not used to avoid false postives (with, e.g., "Centre Pompidou"). To match this old region name, there must be "region centre" or "conseil regional centre" in the input text.