Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [NETCETERA] add sdk-type and default-sdk-type in netcetera authentication request #7156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add sdk-type and default-sdk-type in netcetera authentication request
add sdk-type in SDK Information of PaymentsExternalAuthenticationRequest

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Sanity External Authentication Request through Mobile SDK
    CURL
curl --location 'localhost:8080/payments/pay_OxGBWwRs9qH0nJP1CI99/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_74ab7c8aac7c49d793f9c980c544a09f' \
--data '{
    "client_secret": "pay_OxGBWwRs9qH0nJP1CI99_secret_Vw1ItPPePtpz32zI2V9d",
    "device_channel": "APP",
    "threeds_method_comp_ind": "Y",
    "sdk_information": {
        "sdk_app_id": "92deb809-a452-47af-ac3b-301978a9e9e0",
        "sdk_enc_data": "eyJraWQiOiIzYzVlZDMxOTBhOWFlNGI2OTI1NjZiYmZkZTc0ODNiZTI4MDAyMzg4IiwiZW5jIjoiQTEyOEdDTSIsImFsZyI6IlJTQS1PQUVQLTI1NiJ9.at-tUcn4zXOCzxRdP7FB6cpSLsC9M5fKRCLZrup6nIkwfV80aa0.rQ2YtC2RZvW-LeznAErdMg",
        "sdk_ephem_pub_key": {
            "kty": "EC",
            "x": "P5zWKpoAZoUlrtUoe6Xzvia3zgCX1mSmpGj5XlV9R0w",
            "y": "ov2s2HF_HVwf2vzZMPOLjGwFASSmEGxeSUEuyMcrhLI",
            "crv": "P-256"
        },
        "sdk_trans_id": "4fa7696e-ca08-42cc-806f-1081287a1b9b",
        "sdk_reference_number": "3DS_LOA_SDK_JTPL_020200_00788",
        "sdk_max_timeout": 5
    }
}'

Response

{
    "trans_status": "C",
    "acs_url": null,
    "challenge_request": null,
    "acs_reference_number": "3DS_LOA_ACS_201_13579",
    "acs_trans_id": "c532ad1e-0fb7-438e-a0db-be68405c6bdc",
    "three_dsserver_trans_id": "305f8eaa-43c1-49f0-a5f4-0789b8eae7d1",
    "acs_signed_content": "eyJhbGciOiJQUzI1NiIsIng1YyI6WyJNSUlFRURDQ0F2aWdBd0lCQWdJSWFYL2RWZE9CM0hnd0RRWUpLb1pJaHZjTkFRRUxCUUKQ",
    "three_ds_requestor_url": "https://google.com/"
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration C-bug Category: Bug M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 31, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jan 31, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners January 31, 2025 10:38
Copy link

semanticdiff-com bot commented Jan 31, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/openapi/src/openapi.rs  32% smaller
  crates/router/src/connector/netcetera/netcetera_types.rs  18% smaller
  api-reference/openapi_spec.json  0% smaller
  crates/api_models/src/payments.rs  0% smaller

@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 31, 2025
SanchithHegde
SanchithHegde previously approved these changes Jan 31, 2025
swangi-kumari
swangi-kumari previously approved these changes Jan 31, 2025
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants