feat(connector): introduce feature_matrix api to coinbase, iatapay, nexixpay and square
#7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
pixincreate
added
A-connector-integration
pixincreate
force-pushed
the
connector/feature_matrix
branch
4 times, most recently
from
04f14a8 to
53b522b
Compare
pixincreate
force-pushed
the
connector/feature_matrix
branch
from
53b522b to
5097104
Compare
pixincreate
force-pushed
the
connector/feature_matrix
branch
from
0a070f6 to
d47a0b5
Compare
pixincreate
requested review from
SanchithHegde and
Chethan-rao
and removed request for
SanchithHegde
pixincreate
force-pushed
the
connector/feature_matrix
branch
from
7f0f983 to
22c3cdb
Compare
…is enabled (core does not call validation if feature matrix is implemented)
pixincreate
force-pushed
the
connector/feature_matrix
branch
from
22c3cdb to
83fe8d7
Compare
AkshayaFoiger
previously approved these changes
Feb 24, 2025
deepanshu-iiitu
requested changes
Feb 24, 2025
deepanshu-iiitu
approved these changes
Feb 25, 2025
ShankarSinghC
approved these changes
Feb 26, 2025
AkshayaFoiger
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
this pr introduces feature_matrix api to 4 more connectors and in addition to that, pm filters also have been updated.
have written many scripts to verify the pm_filters and are attached in the issue
Additional Changes
Motivation and Context
With this PR, we'll be increasing the
feature_matrixcoverage for connectors by implementingConnectorSpecificationsjust so that it will be the single source of truth for getting information about the payment methods and payment method types that the connector supports.How did you test it?
tested by making a request to the feature matrix endpoint:
request:
response:
{ "connector_count": 7, "connectors": [ { "name": "BAMBORA", "display_name": "Bambora", "description": "Bambora is a leading online payment provider in Canada and United States.", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "card", "payment_method_type": "credit", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "supported", "no_three_ds": "supported", "supported_card_networks": [ "Visa", "Mastercard", "AmericanExpress", "Discover", "JCB", "DinersClub" ], "supported_countries": [ "US", "CA" ], "supported_currencies": [ "USD" ] } ], "supported_webhook_flows": [] }, { "name": "COINBASE", "display_name": "Coinbase is a place for people and businesses to buy, sell, and manage crypto.", "description": "Square is the largest business technology platform serving all kinds of businesses.", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "crypto", "payment_method_type": "crypto_currency", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "supported_countries": [ "VN", "US", "DE", "BR", "SG", "FR", "ZA", "ES", "GB", "CA", "IT", "TR", "NL", "PT", "AU" ], "supported_currencies": null } ], "supported_webhook_flows": [ "payments", "refunds" ] }, { "name": "DEUTSCHEBANK", "display_name": "Deutsche Bank", "description": "Deutsche Bank is a German multinational investment bank and financial services company ", "category": "bank_acquirer", "supported_payment_methods": [ { "payment_method": "bank_debit", "payment_method_type": "sepa", "mandates": "supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "supported_countries": null, "supported_currencies": null }, { "payment_method": "card", "payment_method_type": "debit", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "supported", "no_three_ds": "not_supported", "supported_card_networks": [ "Visa", "Mastercard" ], "supported_countries": null, "supported_currencies": null }, { "payment_method": "card", "payment_method_type": "credit", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "supported", "no_three_ds": "not_supported", "supported_card_networks": [ "Visa", "Mastercard" ], "supported_countries": null, "supported_currencies": null } ], "supported_webhook_flows": [] }, { "name": "IATAPAY", "display_name": "Iatapay", "description": "IATA Pay is a payment method for travellers to pay for air tickets purchased online by directly debiting their bank account.", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "bank_redirect", "payment_method_type": "local_bank_redirect", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "GB", "SG", "LV", "ES", "TH", "AU", "LT", "IE", "MX", "PT", "GH", "FI", "DE", "VN", "FR", "PH", "IN", "JO", "MY", "EE", "HK", "IT", "NL", "CO", "BE", "BR", "LU", "AT" ], "supported_currencies": [ "GBP", "INR", "AUD", "SGD", "EUR", "MXN", "VND", "PHP", "BRL", "MYR", "THB", "HKD", "COP", "JOD", "GHS" ] }, { "payment_method": "bank_redirect", "payment_method_type": "ideal", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "NL" ], "supported_currencies": [ "EUR" ] }, { "payment_method": "real_time_payment", "payment_method_type": "fps", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "GB" ], "supported_currencies": [ "GBP" ] }, { "payment_method": "real_time_payment", "payment_method_type": "viet_qr", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "VN" ], "supported_currencies": [ "VND" ] }, { "payment_method": "real_time_payment", "payment_method_type": "duit_now", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "MY" ], "supported_currencies": [ "MYR" ] }, { "payment_method": "real_time_payment", "payment_method_type": "prompt_pay", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "TH" ], "supported_currencies": [ "THB" ] }, { "payment_method": "upi", "payment_method_type": "upi_intent", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "IN" ], "supported_currencies": [ "INR" ] }, { "payment_method": "upi", "payment_method_type": "upi_collect", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "IN" ], "supported_currencies": [ "INR" ] } ], "supported_webhook_flows": [ "payments", "refunds" ] }, { "name": "NEXIXPAY", "display_name": "Nexixpay", "description": "Nexixpay is an Italian bank that specialises in payment systems such as Nexi Payments (formerly known as CartaSi).", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "card", "payment_method_type": "debit", "mandates": "supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "supported", "no_three_ds": "supported", "supported_card_networks": [ "Visa", "Mastercard", "AmericanExpress", "JCB" ], "supported_countries": [ "BA", "HR", "GB", "DK", "PL", "US", "GI", "HU", "MK", "CZ", "CH", "RS", "SE", "BG", "RO", "UA", "IS" ], "supported_currencies": [ "BGN", "CHF", "HUF", "HRK", "CZK", "RSD", "UAH", "SEK", "GIP", "RON", "ISK", "USD", "PLN", "GBP", "MKD", "DKK", "BAM" ] }, { "payment_method": "card", "payment_method_type": "credit", "mandates": "supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "supported", "no_three_ds": "supported", "supported_card_networks": [ "Visa", "Mastercard", "AmericanExpress", "JCB" ], "supported_countries": [ "RO", "PL", "CH", "UA", "MK", "BA", "CZ", "HU", "SE", "US", "HR", "RS", "DK", "GB", "IS", "BG", "GI" ], "supported_currencies": [ "MKD", "CHF", "HUF", "BGN", "CZK", "ISK", "RSD", "GIP", "SEK", "BAM", "GBP", "USD", "HRK", "RON", "PLN", "DKK", "UAH" ] } ], "supported_webhook_flows": [] }, { "name": "SQUARE", "display_name": "Square", "description": "Square is the largest business technology platform serving all kinds of businesses.", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "card", "payment_method_type": "debit", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "not_supported", "no_three_ds": "supported", "supported_card_networks": [ "Visa", "Mastercard", "AmericanExpress", "Discover", "UnionPay", "Interac", "JCB" ], "supported_countries": [ "GB", "ES", "US", "AU", "CA", "FR", "JP", "IE" ], "supported_currencies": [ "MWK", "GIP", "MOP", "AWG", "KMF", "NGN", "TMT", "LKR", "CRC", "HNL", "MXN", "QAR", "BMD", "SYP", "NOK", "AMD", "GYD", "UZS", "XCD", "SLE", "BZD", "GBP", "EUR", "SZL", "TTD", "KYD", "MNT", "KPW", "WST", "RON", "HKD", "GHS", "MUR", "USD", "HRK", "INR", "PYG", "UGX", "LAK", "OMR", "SSP", "HUF", "FJD", "GTQ", "BBD", "MMK", "SRD", "MKD", "CZK", "AUD", "TJS", "ZAR", "RSD", "GEL", "LRD", "AOA", "GNF", "ISK", "NAD", "BGN", "IRR", "BND", "THB", "KRW", "BHD", "TOP", "PHP", "MYR", "UYU", "BSD", "DOP", "SBD", "SVC", "MVR", "EGP", "TRY", "SDG", "KHR", "MAD", "MGA", "SLL", "CDF", "NZD", "TND", "TZS", "VUV", "BAM", "ANG", "NPR", "XOF", "BWP", "XPF", "MDL", "BTN", "DZD", "ETB", "LYD", "IDR", "IQD", "BIF", "CHF", "JPY", "SAR", "KGS", "JOD", "KWD", "PKR", "UAH", "KES", "MZN", "GMD", "LBP", "PAB", "SCR", "YER", "JMD", "ERN", "CNY", "XAF", "BOB", "BDT", "ARS", "PEN", "RUB", "AZN", "KZT", "CAD", "SHP", "CVE", "NIO", "DJF", "HTG", "AED", "BRL", "COP", "DKK", "PLN", "SOS", "SGD", "LSL", "ALL", "ZMW", "PGK", "CLP", "FKP", "AFN", "ILS", "VND", "RWF", "CUP", "SEK", "TWD" ] }, { "payment_method": "card", "payment_method_type": "credit", "mandates": "not_supported", "refunds": "supported", "supported_capture_methods": [ "automatic", "manual", "sequential_automatic" ], "three_ds": "not_supported", "no_three_ds": "supported", "supported_card_networks": [ "Visa", "Mastercard", "AmericanExpress", "Discover", "UnionPay", "Interac", "JCB" ], "supported_countries": [ "JP", "ES", "IE", "AU", "CA", "GB", "FR", "US" ], "supported_currencies": [ "SRD", "SCR", "CLP", "SLL", "VUV", "NIO", "ANG", "DOP", "OMR", "TZS", "IQD", "BIF", "CDF", "ILS", "PAB", "CNY", "ETB", "BDT", "BGN", "SHP", "KHR", "SVC", "AUD", "JOD", "RSD", "IDR", "KGS", "EGP", "SSP", "TND", "XPF", "BND", "ISK", "GHS", "KYD", "GIP", "MGA", "TOP", "TRY", "USD", "RWF", "COP", "BHD", "BBD", "MWK", "WST", "BWP", "XOF", "AMD", "MOP", "QAR", "AFN", "NAD", "PHP", "ALL", "XCD", "AWG", "CZK", "HKD", "GBP", "GNF", "GMD", "NOK", "ERN", "RUB", "PEN", "SBD", "AED", "DJF", "ZMW", "DZD", "UAH", "AOA", "NPR", "HUF", "PKR", "LBP", "DKK", "HNL", "KES", "CHF", "NGN", "SEK", "TWD", "MAD", "FJD", "PYG", "BOB", "JPY", "JMD", "BTN", "LRD", "MNT", "SLE", "SOS", "TTD", "ZAR", "KWD", "UGX", "BAM", "RON", "TJS", "GYD", "NZD", "CAD", "TMT", "MMK", "BRL", "SGD", "UYU", "SZL", "FKP", "SAR", "ARS", "GEL", "LAK", "MZN", "VND", "BSD", "LYD", "UZS", "XAF", "MVR", "PLN", "LKR", "SYP", "HRK", "BZD", "KPW", "PGK", "EUR", "MYR", "GTQ", "YER", "MUR", "CRC", "CUP", "IRR", "KRW", "MXN", "AZN", "BMD", "HTG", "KMF", "INR", "KZT", "LSL", "MDL", "SDG", "THB", "CVE", "MKD" ] } ], "supported_webhook_flows": [ "payments", "refunds" ] }, { "name": "ZSL", "display_name": "ZSL", "description": "Zsl is a payment gateway operating in China, specializing in facilitating local bank transfers", "category": "payment_gateway", "supported_payment_methods": [ { "payment_method": "bank_transfer", "payment_method_type": "local_bank_transfer", "mandates": "not_supported", "refunds": "not_supported", "supported_capture_methods": [ "automatic" ], "supported_countries": [ "CN" ], "supported_currencies": [ "CNY" ] } ], "supported_webhook_flows": [] } ] }Iatapay does support refunds. They have mentioned it in general that refunds are supported. And upon testing (intent creation, sync and refund), all working fine.
Checklist
cargo +nightly fmt --allcargo clippy --all-features --all-targets -- -D warnings