New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address Rust 1.85.0 clippy lints #7376

Open

GauravRawat369 wants to merge 2 commits into main from clippy-lints

GauravRawat369 commented Feb 25, 2025 •

edited

Loading

Type of Change

Description

This PR addresses the clippy lints occurring due to new rust version 1.85.0
https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible


          Address any new clippy lints introduced in new version of rust (1.85.0)

f29c3de

GauravRawat369 requested review from a team as code owners

February 25, 2025 12:54

semanticdiff-com bot commented Feb 25, 2025 •

edited

Loading

Review changes with

Changed Files

File	Status
crates/router/src/compatibility/stripe/payment_intents/types.rs	82% smaller
crates/router/src/compatibility/stripe/setup_intents/types.rs	82% smaller
crates/router/src/core/payments/tokenization.rs	75% smaller
crates/router/src/core/admin.rs	71% smaller
crates/router/src/core/payments/operations/payment_create.rs	4% smaller
crates/router/src/core/payments/transformers.rs	2% smaller
crates/router/src/types/api/admin.rs	2% smaller
crates/router/src/core/payment_methods/cards.rs	1% smaller
crates/hyperswitch_domain_models/src/customer.rs	0% smaller
crates/hyperswitch_domain_models/src/errors/api_error_response.rs	0% smaller
crates/router/src/core/customers.rs	0% smaller
crates/router/src/core/payment_methods.rs	0% smaller
crates/router/src/core/payments/operations/payment_complete_authorize.rs	0% smaller
crates/router/src/core/payments/operations/payment_update.rs	0% smaller
crates/router/src/core/payouts/helpers.rs	0% smaller
crates/router/src/services/authorization/roles.rs	0% smaller

GauravRawat369 requested a review from Chethan-rao

February 25, 2025 12:54

GauravRawat369 self-assigned this

GauravRawat369 added the C-refactor label


          chore: run formatter

d252ba7

Chethan-rao requested changes

View reviewed changes

crates/router/src/core/customers.rs

    
            @@ -197,7 +197,7 @@ impl CustomerCreateBridge for customers::CustomerRequest {
          
                      customer: &'a domain::Customer,

                  ) -> errors::CustomerResponse<customers::CustomerResponse> {

                      let address = self.get_address();

                      let address_details = address.map(api_models::payments::AddressDetails::from);

                      let address_details = address;

Contributor

Chethan-rao Feb 25, 2025

remove this unnecessary assignment

crates/router/src/core/customers.rs

    
            @@ -1265,7 +1265,7 @@ impl CustomerUpdateBridge for customers::CustomerUpdateRequest {
          
                      customer: &'a domain::Customer,

                  ) -> errors::CustomerResponse<customers::CustomerResponse> {

                      let address = self.get_address();

                      let address_details = address.map(api_models::payments::AddressDetails::from);

                      let address_details = address;

Contributor

Chethan-rao Feb 25, 2025

remove this unnecessary assignment

crates/router/src/core/payments/operations/payment_complete_authorize.rs

    
            @@ -283,7 +283,7 @@ impl<F: Send + Clone + Sync> GetTracker<F, PaymentData<F>, api::PaymentsRequest>
          
                      payment_intent.metadata = request.metadata.clone().or(payment_intent.metadata);

                      // The operation merges mandate data from both request and payment_attempt

                      let setup_mandate = mandate_data.map(Into::into);

                      let setup_mandate = mandate_data;

Contributor

Chethan-rao Feb 25, 2025

remove this unnecessary assignment

Author

GauravRawat369 Feb 26, 2025 •

edited

Loading

pub struct PaymentData
where
F: Clone,
{
pub flow: PhantomData,
pub payment_intent: storage::PaymentIntent,
............................
pub setup_mandate: Option,
pub customer_acceptance: Option,
..........................,

}
setup-mandate is described in PaymentData should I change this to mandate_data?
Doing this will break other things

crates/router/src/core/payments/operations/payment_create.rs

                           .transpose()?;
                       // The operation merges mandate data from both request and payment_attempt
-                      let setup_mandate = mandate_data.map(MandateData::from);
+                      let setup_mandate = mandate_data;

Contributor

Chethan-rao Feb 25, 2025

remove this unnecessary assignment

crates/router/src/core/payments/operations/payment_update.rs

    
            @@ -421,7 +421,7 @@ impl<F: Send + Clone + Sync> GetTracker<F, PaymentData<F>, api::PaymentsRequest>
          
                          .transpose()?;

                      // The operation merges mandate data from both request and payment_attempt

                      let setup_mandate = mandate_data.map(Into::into);

                      let setup_mandate = mandate_data;

Contributor

Chethan-rao Feb 25, 2025

remove this unnecessary assignment

crates/router/src/services/authorization/roles.rs

    
            @@ -165,7 +165,7 @@ impl From<diesel_models::role::Role> for RoleInfo {
          
                      Self {

                          role_id: role.role_id,

                          role_name: role.role_name,

                          groups: role.groups.into_iter().map(Into::into).collect(),

                          groups: role.groups.into_iter().collect(),

Contributor

Chethan-rao Feb 25, 2025

Suggested change

      
                        groups: role.groups.into_iter().collect(),
          
                        groups: role.groups,

Chethan-rao requested a review from SanchithHegde

February 25, 2025 16:25

Chethan-rao linked an issue

that may be closed by this pull request

chore: address Rust 1.85.0 clippy lints #7375

Open

SanchithHegde changed the title ~~chore: address Rust 1.85.0 clippy lints #7375~~ chore: address Rust 1.85.0 clippy lints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels