Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [NETCETERA] use prod instead of prev in base_url for production config #7381

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix(connector): [NETCETERA] use prod instead of prev in base_url for production config #7381

merged 1 commit into from
Feb 26, 2025

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

use prod instead of prev in base_url for production config

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

PROD Base URL change only, No test cases required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added C-bug Category: Bug M-configuration-changes Metadata: This PR involves configuration changes labels Feb 26, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Feb 26, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner February 26, 2025 10:51
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 2519722 Feb 26, 2025
19 of 24 checks passed
@likhinbopanna likhinbopanna deleted the fix-netcetera-prod-url branch February 26, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahkal sahkal sahkal approved these changes

@hrithikesh026 hrithikesh026 hrithikesh026 approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
C-bug Category: Bug M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
February 2025 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sai-harsha-vardhan @sahkal @hrithikesh026 @ShankarSinghC @likhinbopanna