removed check-for-duplicates in s3 move adhoc task as it was preventi…

…ng task retries
justinhunt · Apr 23, 2024 · 731f5de · 731f5de
1 parent 7fda397
commit 731f5de
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,5 +1,8 @@
 Change List
 =========
+Version 3.1.79 (Build 2024042301)
+ - Removed check-for-duplicates in adhoc_s3_move task, as it was not working as intended, and causing files to not be retrieved
+
 Version 3.1.78 (Build 2024042300)
  -  Added logging to taskrunner, and created a 3 minute window before trashing ad hoc tasks that fail. To give task runner a chance at them.
 

diff --git a/classes/task/adhoc_s3_move.php b/classes/task/adhoc_s3_move.php
@@ -162,7 +162,7 @@ protected function do_retry($reason, $trace, $customdata, $delay) {
         //if we do not set the next run time it can extend the current cron job indef with a recurring task
         $s3_task->set_next_run_time(time()+$delay);
         // queue it
-        $checkforduplicates=true;
+        $checkforduplicates=false;
         \core\task\manager::queue_adhoc_task($s3_task,$checkforduplicates);
     }
 

diff --git a/version.php b/version.php
@@ -25,8 +25,8 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2024042300;
+$plugin->version = 2024042301;
 $plugin->requires = 2016052300;//moodle 3.1.0
 $plugin->component = 'filter_poodll';
 $plugin->maturity = MATURITY_STABLE;
-$plugin->release = '3.1.78 (Build 2024042300)';
+$plugin->release = '3.1.79 (Build 2024042301)';