Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Modernize loadPlaylist function with types and logic #98

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[Improvement] Modernize loadPlaylist function with types and logic #98

merged 3 commits into from
Nov 15, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Update typing for loadPlaylist
    • Support JwPlaylistItem and string for URL
  • Update Native code to support above
  • Places TODO for when iOS exposes more options in the JWJSONParser

Why is this Pull Request needed?

  • Fix TS definitions
  • Allow more flexibility in the loadPlaylist method

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner October 18, 2024 16:08
edougher
edougher approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@edougher edougher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jmilham21 Jmilham21 merged commit cb002b7 into master Nov 15, 2024
@Jmilham21 Jmilham21 deleted the improvement/typing-and-updates-for-load-playlist branch November 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edougher edougher edougher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @edougher