Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial draft of making close faster for productive use (interesting … #23

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jxsl13
Copy link
Owner

@jxsl13 jxsl13 commented Jul 28, 2023

…forusing this library in integration tests w/o leak tests)

…forusing this library in integration tests w/o leak tests)
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #23 (2b9c7d0) into main (b8258be) will increase coverage by 0.19%.
Report is 1 commits behind head on main.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   59.91%   60.11%   +0.19%     
==========================================
  Files          21       21              
  Lines        2435     2457      +22     
==========================================
+ Hits         1459     1477      +18     
- Misses        833      837       +4     
  Partials      143      143              
Files Changed Coverage Δ
pool/connection_pool_options.go 35.13% <0.00%> (-2.01%) ⬇️
pool/pool_options.go 27.08% <0.00%> (-2.47%) ⬇️
pool/connection.go 77.09% <80.00%> (+0.25%) ⬆️
pool/connection_options.go 70.00% <100.00%> (+3.33%) ⬆️
pool/connection_pool.go 68.57% <100.00%> (+0.92%) ⬆️
pool/pool.go 76.47% <100.00%> (+0.71%) ⬆️

... and 1 file with indirect coverage changes

@jxsl13 jxsl13 merged commit 7b10bb0 into main Jul 28, 2023
7 checks passed
@john-behm-bertelsmann john-behm-bertelsmann deleted the feature/slow-close-option branch January 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant