Handle IndexError from embedded interpreter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my environment we are using a Jython Interpreter embedded in a larger application. After upgrading from a much older version to 2.7.2 we started getting an IndexError that hosed things. The comment below the modified line notes that sys.argv isn't handled properly in embedded interpreters I suspect that there was a change alsewhere that changed sys.argv from being undefined to being an empty list but that is just speculation. Regardless this change gets things working in our embedded environment.
|
https://bugs.python.org/issue32573 and PEP-587 refer to this problem and favours setting For 2.7 we have https://docs.python.org/2/c-api/init.html#c.Py_SetProgramName as a clue to what maybe ought to happen. However, this PR is closest to preserving existing behaviour which seems the best for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment we are using a Jython Interpreter embedded in a larger application. After upgrading from a much older version to 2.7.2 we started getting an IndexError that hosed things. The comment below the modified line notes that sys.argv isn't handled properly in embedded interpreters I suspect that there was a change alsewhere that changed sys.argv from being undefined to being an empty list but that is just speculation. Regardless this change gets things working in our embedded environment.